Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase obviousness of how to remove a term in a term-input #243

Closed
nilmerg opened this issue Jan 20, 2025 · 2 comments · Fixed by #249
Closed

Increase obviousness of how to remove a term in a term-input #243

nilmerg opened this issue Jan 20, 2025 · 2 comments · Fixed by #249
Assignees
Milestone

Comments

@nilmerg
Copy link
Member

nilmerg commented Jan 20, 2025

At the moment a term can be removed by clicking on it. This must not change. However, the indication of this functionality needs to be improved. Hovering over a term shows a trash icon on the left hand. The color doesn't change.

The trash icon must be shown in the middle over the term and have a reddish color. The term's label must have a grayish color then.

@nilmerg nilmerg added enhancement New feature or request and removed enhancement New feature or request labels Jan 20, 2025
@flourish86
Copy link
Contributor

What do you think of these solutions?

I see some advantages over what you've suggested:

  • having a dedicated click area for deletion prevents the user from accidentally removing items
  • A label makes it clear what will happen
  • The user icon is part of the label and is independent from the delete action

I'm aware of the larger implementation effort, since there are more changes to do. But since we're working on "global" element, I think it's worth it.

  1. Compact: Hovering makes delete button appear
Screen.Recording.2025-02-05.at.14.46.25.mov
  1. Always visible delete button. In case of Contacts in Notifications we should have enough space
Screen.Recording.2025-02-05.at.14.46.25.mov

If you insist on keeping the whole element clickable for deletion, I'd suggest this design, though.

  1. Hover button and label replace label
Screen.Recording.2025-02-05.at.15.05.49.mov

@ncosta-ic ncosta-ic self-assigned this Feb 7, 2025
@nilmerg
Copy link
Member Author

nilmerg commented Feb 11, 2025

I tend to the third solution. Remember, the input variation you showed is arranged vertically. There is a horizontal mode as well, where the width of terms is not that large.

@ncosta-ic ncosta-ic assigned ncosta-ic and unassigned ncosta-ic Feb 18, 2025
nilmerg added a commit that referenced this issue Mar 21, 2025
…#249)

This PR changes the way by which the user gets hinted about the
possibility to remove an entry out of a read-only list of term-input
values.

Resolves: #243
@nilmerg nilmerg added this to the v0.11.0 milestone Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants