FIXUP and REWRITE: Comment out unused and unreachable code

Author: jrauh01

library/Vspheredb/DbObject/DistributedVirtualSwitch.php

@@ -51,19 +51,6 @@ public function setUplinkPortGroups(array $portGroups): void
         var_dump($portGroups);
     }
 
-    /**
-     * @param array $portGroups
-     *
-     * @return void
-     */
-    public function XXXXsetPortGroups(array $portGroups): void
-    {
-        $newSum = $this->calculateMorefsChecksum($portGroups);
-        if ($this->get('portgroups_checksum') !== $newSum) {
-            $this->scheduleNewPortgroupRefs($portGroups);
-        }
-    }
-
     /**
      * @param ManagedObjectReference[] $hostMembers
      *
@@ -73,13 +60,6 @@ public function setHostMembers(array $hostMembers): void
     {
         var_dump('HOSTMEMBERS');
         var_dump($hostMembers);
-
-//        return;
-//
-//        $newSum = $this->calculateMorefsChecksum($hostMembers);
-//        if ($this->get('hostmembers_checksum') !== $newSum) {
-//            $this->scheduleNewPortgroupRefs($hostMembers);
-//        }
     }
 
     /**
@@ -92,17 +72,6 @@ protected function scheduleNewPortgroupRefs(array $portGroups): void
         $this->unstoredPortGroupRefs = $portGroups;
     }
 
-    protected function onStore(): void
-    {
-//        if (false && $this->unstoredPortGroupRefs) {
-//            $this->replaceMoRefs(
-//                $this->get('uuid'),
-//                'distributed_switch_portgroup',
-//                $this->unstoredPortGroupRefs
-//            );
-//        }
-    }
-
     /**
      * @param string $uuid
      * @param string $table

library/Vspheredb/PerformanceData/IcingaRrd/RrdImg.php

@@ -76,7 +76,6 @@ protected static function prepareImg(string $moref, string $device, string $temp
         $width = 340;
         $height = 180;
         $end = floor(time() / 300) * 300;
-        // $start = $end - 86400;
         $start = $end - 14400;
         $params = [
             'file'     => sprintf('%s/%s.rrd', $moref, $device),

library/Vspheredb/Polling/CurlOptions.php

@@ -23,24 +23,12 @@ public static function forServerInfo(ServerInfo $server): array
     {
         $host = $server->get('host');
         if (preg_match('/^(.+?):(\d{1,5})$/', $host, $match)) {
-            // $host = $match[1];
             $port = (int) $match[2];
         } else {
             $port = null;
         }
-        $options = [
-            CURLOPT_HTTPHEADER => [
-                // Host header disabled for now, see #496
-                // "Host: $host",
-                'Expect:',
-                'User-Agent: Icinga-vSphereDB/1.8'
-            ]
-        ];
-
-        // Unused, we're authenticating via SOAP
-        // if (null !== ($username = $server->get('username'))) {
-        //     $options[CURLOPT_USERPWD] = sprintf('%s:%s', $username, $server->get('password'));
-        // }
+        $options = [CURLOPT_HTTPHEADER => ['Expect:', 'User-Agent: Icinga-vSphereDB/1.8']];
+        $options[CURLOPT_HTTPHEADER] = ['Expect:', 'User-Agent: Icinga-vSphereDB/1.8'];
 
         if ($proxyType = $server->get('proxy_type')) {
             // TODO: Depending on the PHP and Curl version, we might want to support HTTPS proxies

library/Vspheredb/Web/OverviewTree.php

@@ -55,13 +55,6 @@ protected function getTree(): array
         $tree = [];
         $all = [];
         foreach ($this->fetchTree() as $item) {
-//            if (
-//                $this->typeFilter
-//                && (string) $item->parent_object_type === 'Datacenter'
-//                && $item->object_name !== $this->typeFilter
-//            ) {
-                // continue; // see #260
-//            }
             $item->children = [];
 
             /** @var string $uuid */

library/Vspheredb/Web/Widget/CalendarMonthSummary.php

@@ -212,7 +212,6 @@ protected function weekRow($cw): HtmlElement
     protected function getMonthName(): string
     {
         return $this->timeFormat->getMonthName($this->getMonthAsTimestamp());
-//        return date('F', $this->getMonthAsTimestamp());
     }
 
     protected function createWeekdayHeader(): HtmlElement

library/Vspheredb/Web/Widget/CpuAbsoluteUsage.php

@@ -20,9 +20,6 @@ public function __construct(int $mhz, ?int $cores = null, int $perCore = 2000)
     {
         $class = null;
         if ($cores !== null) {
-//            if (false) {
-//                $this->add(Html::tag('span', ['class' => 'cpu-count'], sprintf($this->translate('%d CPUs'), $cores)));
-//            }
             $usedPerCore = $mhz / $cores;
             if ($usedPerCore / $perCore > 0.7) {
                 $class = 'critical';

library/Vspheredb/Web/Widget/VmHardwareTree.php

@@ -138,13 +138,6 @@ protected function renderDisk(object $disk, object $device, object $controller):
             $result[] = Format::bytes($disk->capacity);
         }
 
-//        if (false && array_key_exists($scsi, $this->diskPerf)) {
-//            $result[] = new CompactInOutSparkline(
-//                $this->diskPerf[$scsi][171],
-//                $this->diskPerf[$scsi][172]
-//            );
-//        }
-
         return $result;
     }
 
@@ -186,13 +179,6 @@ protected function linkToPortGroup($uuid): string
         }
 
         return sprintf('%s (%d NICs)', $info->object_name, $info->cnt_nics);
-
-        // TODO:
-//        return Link::create(
-//            sprintf('%s (%d NICs)', $info->object_name, $info->cnt_nics),
-//            'vspheredb/portgroup',
-//            Util::uuidParams($info->uuid)
-//        );
     }
 
     protected function fetchDiskPerf(): array