Skip to content

Commit 61f8a68

Browse files
Add forward compatible return types (#620)
Add bool return type to `isValidEvent()` of `PerfDataConsumerForm` and `VCenterShipMetricsForm` to ensure forward compatibility with ipl-html and ipl-stdlib.
1 parent 6986299 commit 61f8a68

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

library/Vspheredb/Web/Form/PerfdataConsumerForm.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public function assemble()
5656
$this->addButtons(isset($implementation), 'implementation');
5757
}
5858

59-
public function isValidEvent($event)
59+
public function isValidEvent($event): bool
6060
{
6161
if ($event === self::ON_DELETE) {
6262
return true;

library/Vspheredb/Web/Form/VCenterShipMetricsForm.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ protected function addConsumerConfig($consumer)
121121
}
122122
}
123123

124-
public function isValidEvent($event)
124+
public function isValidEvent($event): bool
125125
{
126126
if ($event === self::ON_DELETE) {
127127
return true;

0 commit comments

Comments
 (0)