refactor: 피드백 수정 API 파라미터 수정

Author: 82everywin

src/main/java/com/neeis/neeis/domain/attendance/controller/AttendanceController.java

@@ -76,7 +76,7 @@ public ResponseEntity<CommonResponse<StudentAttendanceResDto>> getOneAttendance(
 
     @GetMapping("/summary")
     @Operation(summary = "[교사 및 학생 전용] 담임 학생 출결 통계 조회", description = "로그인한 교사의 학급 학생의 출결을 통계냅니다. <br>" +
-            "조회하려는 학급과 학생의 년도, 학년, 반, 출석번호이 필수로 입력해야합니다. <br>" +
+            "조회하려는 학급과 학생의 년도, 학년, 반, 출석번호가 필수로 입력해야합니다. <br>" +
             "추가로 출석 통계는 '학기당 수업 일수'로 계산되므로, 반드시 '학기'를 입력해야 합니다.")
     public ResponseEntity<CommonResponse<StudentAttendanceSummaryDto>> getStudentAttendanceSummary( @AuthenticationPrincipal UserDetails userDetails,
                                                                                                     @RequestParam("year") @Parameter(description = "연도") int year,
@@ -101,15 +101,18 @@ public ResponseEntity<CommonResponse<AttendanceFeedbackResDto>> saveFeedback(@Au
         return ResponseEntity.ok(CommonResponse.from(SUCCESS_POST_FEEDBACK.getMessage(), dto));
     }
 
-    @PutMapping("/feedback/{feedbackId}")
+    @PutMapping("/feedback")
     @Operation(summary = "[교사 전용] 담임 학생 출결 피드백 수정", description = "로그인한 교사가 작성한 학생 출결 피드백을 수정합니다. <br>" +
-                    "피드백 ID를 경로로 입력하고, 수정할 피드백 내용을 요청 본문에 작성합니다. <br>" +
+                    "수정하려는 학생의 년도, 학년, 반, 출석번호가 필수로 입력해야합니다. <br>" +
                     "본인이 작성한 피드백만 수정할 수 있습니다.")
     public ResponseEntity<CommonResponse<AttendanceFeedbackResDto>> updateFeedback(@AuthenticationPrincipal UserDetails userdetails,
-                                                                 @PathVariable("feedbackId") Long feedbackId,
+                                                               @RequestParam("year") @Parameter(description = "연도") int year,
+                                                               @RequestParam("grade") @Parameter(description = "학년") int grade,
+                                                               @RequestParam("classNum") @Parameter(description = "반") int classNum,
+                                                               @RequestParam("number") @Parameter(description = "번호") int number,
                                                                  @Valid @RequestBody AttendanceFeedbackReqDto attendanceFeedbackDto) {
 
-        return ResponseEntity.ok(CommonResponse.from(SUCCESS_POST_FEEDBACK.getMessage(),attendanceService.updateFeedback(userdetails.getUsername(), feedbackId, attendanceFeedbackDto)));
+        return ResponseEntity.ok(CommonResponse.from(SUCCESS_POST_FEEDBACK.getMessage(),attendanceService.updateFeedback(userdetails.getUsername(),year, grade, classNum, number, attendanceFeedbackDto)));
     }
 
     @GetMapping("/feedback")

src/main/java/com/neeis/neeis/domain/attendance/service/AttendanceService.java

@@ -62,7 +62,7 @@ public void saveOrUpdateAttendance(String username, AttendanceBulkRequestDto req
         Teacher teacher = teacherService.authenticate(username);
         Classroom classroom = classroomService.findClassroom(requestDto.getYear(), requestDto.getGrade(), requestDto.getClassNumber(), teacher.getId());
 
-        if(classroom.getTeacher() != teacher) {
+        if (classroom.getTeacher() != teacher) {
             throw new CustomException(HANDLE_ACCESS_DENIED);
         }
 
@@ -146,7 +146,7 @@ public List<StudentAttendanceResDto> getAttendances(String username, int year, i
                                     .build())
                             .toList();
 
-                    return StudentAttendanceResDto.toDto( cs,
+                    return StudentAttendanceResDto.toDto(cs,
                             attendances.isEmpty() ? Attendance.builder().student(student).build() : attendances.getFirst(),
                             dailyAttendanceDtos
                     );
@@ -248,14 +248,17 @@ public AttendanceFeedbackResDto saveFeedback(String username, int year, int grad
 
     // [교사] 출결 피드백 수정
     @Transactional
-    public AttendanceFeedbackResDto updateFeedback(String username, Long feedBackId, AttendanceFeedbackReqDto requestDto) {
+    public AttendanceFeedbackResDto updateFeedback(String username, int year, int grade, int classNum, int number, AttendanceFeedbackReqDto requestDto) {
 
         Teacher teacher = teacherService.authenticate(username);
 
-        AttendanceFeedback feedback = feedbackRepository.findById(feedBackId)
-                .orElseThrow(() -> new CustomException(ErrorCode.DATA_NOT_FOUND));
+        ClassroomStudent classroomStudent = checkValidate(username, year, grade, classNum, number);
+
+        AttendanceFeedback feedback = feedbackRepository.findByClassroomStudent(classroomStudent).orElseThrow(
+                () -> new CustomException(ErrorCode.DATA_NOT_FOUND)
+        );
 
-        if(feedback.getClassroomStudent().getClassroom().getTeacher() != teacher){
+        if (feedback.getClassroomStudent().getClassroom().getTeacher() != teacher) {
             throw new CustomException(HANDLE_ACCESS_DENIED);
         }
         feedback.updateContent(requestDto.getFeedback());
@@ -319,7 +322,7 @@ private ClassroomStudent checkValidate(String username, int year, int grade, int
                         .orElseThrow(() -> new CustomException(CLASSROOM_NOT_FOUND));
 
                 // 자녀가 아니면 접근 불가함.
-                if(!student.getId().equals(classroomStudent.getStudent().getId())){
+                if (!student.getId().equals(classroomStudent.getStudent().getId())) {
                     throw new CustomException(HANDLE_ACCESS_DENIED);
                 }