Skip to content

Commit 14ab01b

Browse files
committed
#18 - document breaking change
Signed-off-by: Lance Drane <[email protected]>
1 parent 87a4e06 commit 14ab01b

File tree

5 files changed

+7
-4
lines changed

5 files changed

+7
-4
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ _If you are upgrading: please see [`UPGRADING.md`](UPGRADING.md)._
3131
### Changed
3232

3333
- **Breaking:** Services now work with multiple Capabilities instead of a single Capability ([!9](https://github.com/INTERSECT-SDK/python-sdk/pull/9)) .
34+
- **Breaking:** Renamed `IntersectClientMessageParams` to `IntersectDirectMessageParams` ([commit](https://github.com/INTERSECT-SDK/python-sdk/commit/ae0dab312b9ebdb87bc5a9bb62404d9b18953dfe))
3435

3536
### Added
3637

UPGRADING.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,8 @@ Additionally, this reserves the `intersect_sdk_call_service` function - if you a
153153

154154
### Clients
155155

156+
`IntersectClientMessageParams` has been renamed to `IntersectDirectMessageParams` because this object can be used in both Clients and in the new Service-to-Service calls.
157+
156158
When calling another Service's operation, the namespacing has changed from `<function_name>` to `<capability_name>.<function_name>` . So for example, if we were calling `my_endpoint` in the above Service example, the code would change from:
157159

158160
```python
@@ -166,7 +168,7 @@ params = IntersectClientMessageParams(
166168
to
167169

168170
```python
169-
params = IntersectClientMessageParams(
171+
params = IntersectDirectMessageParams(
170172
operation='MyCapability.my_endpoint',
171173
# ... other parameters unchanged
172174
)

src/intersect_sdk/_internal/interfaces.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def create_external_request(
4141
"""Observed entity (capabilitiy) tells observer (i.e. service) to send an external request.
4242
4343
Params:
44-
- request: the request we want to send out, encapsulated as an IntersectClientMessageParams object
44+
- request: the request we want to send out, encapsulated as an IntersectDirectMessageParams object
4545
- response_handler: optional callback for how we want to handle the response from this request.
4646
- timeout: optional value for how long we should wait on the request, in seconds (default: 300 seconds)
4747

src/intersect_sdk/capability/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ def intersect_sdk_call_service(
138138
"""Create an external request that we'll send to a different Service.
139139
140140
Params:
141-
- request: the request we want to send out, encapsulated as an IntersectClientMessageParams object
141+
- request: the request we want to send out, encapsulated as an IntersectDirectMessageParams object
142142
- response_handler: optional callback for how we want to handle the response from this request.
143143
- timeout: optional value for how long we should wait on the request, in seconds (default: 300 seconds)
144144

src/intersect_sdk/service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -518,7 +518,7 @@ def create_external_request(
518518
"""Create an external request that we'll send to a different Service.
519519
520520
Params:
521-
- request: the request we want to send out, encapsulated as an IntersectClientMessageParams object
521+
- request: the request we want to send out, encapsulated as an IntersectDirectMessageParams object
522522
- response_handler: optional callback for how we want to handle the response from this request.
523523
- timeout: optional value for how long we should wait on the request, in seconds (default: 300 seconds)
524524

0 commit comments

Comments
 (0)