Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Trigger.crossing_time_expr more robust #37

Open
tclose opened this issue Jan 13, 2018 · 0 comments
Open

Make Trigger.crossing_time_expr more robust #37

tclose opened this issue Jan 13, 2018 · 0 comments
Labels
bug

Comments

@tclose
Copy link
Contributor

tclose commented Jan 13, 2018 •
edited
Loading

The method crossing_time_expr in the Trigger class is used to return an expression in terms of t (time) when the trigger threshold is crossed. Currently it can simple Trigger expressions consisting of a single inequality, or multiple inequality clauses combined by sympy.Or.

However, crossing-time expressions for trigger expressions including sympy.And should be able to be handled using piece-wise expressions (I think). Will require some careful thought though.
@tclose tclose added the bug label Jan 13, 2018
@tclose tclose changed the title Improve Trigger._becomes_true method to handle expressions without 't' Make Trigger.crossing_time_expr more robust Jan 22, 2018
@tclose tclose mentioned this issue Jan 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tclose