Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping the '_layer' from abstraction_layer and user_layer packages #10

Closed
tclose opened this issue May 19, 2015 · 5 comments
Closed

Comments

@tclose
Copy link
Contributor

tclose commented May 19, 2015

This is a minor issue, but I was wondering whether you would object to dropping the layer suffix from the packages relating to layers. As I am usually a bit frustrated by the time I type 'abstraction' let alone the '_layer' part, and I think it would be pretty obvious at that point that they represent the layer structures (even with less obvious names 'structure', 'property' and 'experiment' in future).

@jougs
Copy link

jougs commented May 19, 2015

I think this is a good idea.

@iraikov
Copy link

iraikov commented May 19, 2015

It's an excellent idea, and the abstraction layer needs a more descriptive
name like math or equation.

On Tue, May 19, 2015 at 2:07 AM, Tom Close [email protected] wrote:

This is a minor issue, but I was wondering whether you would object to
dropping the layer suffix from the packages relating to layers. As I am
usually a bit frustrated by the time I type 'abstraction' let alone the
'_layer' part, and I think it would be pretty obvious at that point that
they represent the layer structures (even with less obvious names
'structure', 'property' and 'experiment' in future).


Reply to this email directly or view it on GitHub
#10.

@tclose
Copy link
Contributor Author

tclose commented May 20, 2015

Hi Ivan,

I raised this suggestion (possibly even the same names:) when we were discussing the new layer structure in Gif, but the feeling was that since the abstraction layer was the only layer that was to be left unchanged that it would be confusing to rename it.

However, I think we probably should have a wider discussion about backwards compatibility at some point, as this something that Erik is very keen to maintain, even though I think most of us were only thinking of it from version 2.0 onwards.

(NB: This should probably be discussed on the INCF/nineml issue tracker instead)

@apdavison
Copy link
Member

I am usually a bit frustrated by the time I type 'abstraction' let alone the '_layer' part

This is what tab-completion is for 😉

But seriously, this change is fine with me

@tclose
Copy link
Contributor Author

tclose commented May 22, 2015

This is what tab-completion is for 😉

Yeah, that is the only reason it has lasted this long, however, when I am in an environment without tab-completion it drives me batty ;)

But seriously, this change is fine with me

Okay great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants