-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed #132
Comments
I suspect this is related to #94. Unless you have 100 or more tnz sessions at the same time, I am very skeptical that the asyncio package would make a difference. I suspect you may be used to another emulator that buffers keyboard input while the keyboard is locked waiting for a response from the server. In which case, having zti do that kind of buffering would be the solution. Do you agree with that, or maybe something else is going on? |
Yes that is probably it. Just wondering if it's worth checking with uvloop as it's easier to test compared to implementing input buffering. |
Yeah, #94 wasn't the best reference. I know that buffering has been brought up before though. but I guess there is not an issue for it. I'm going to consider this an issue for it. |
@v1gnesh, if you're willing.. I have a draft PR that I believe will address your issue. To install: pip install git+https://github.com/IBM/tnz@keylock-buffer |
@najohnsn Thank you. I don't know yet if a repository manager is capable of pulling PyPI stuff for pip via a git source. I'll try & report back. |
@najohnsn I tried the above command to install; looks like I can only install from a package (it can be obtained via a repository manager). |
Interesting. I'm not familiar with your "repository manager" environment. Maybe you could download it from here?
I believe that Python will pick up the tnz module from that tnz directory instead of the installed tnz package. |
It's things like Artifactory JFrog or Nexus Repository. |
When switching between screens quickly, I find that I get
Keylock = 1
more often than I'd like.Will it help to switch from the default python asyncio event loop to https://github.com/MagicStack/uvloop ?
If it improves the situation, it's fine if it isn't merged into the main branch, but is instead available as a flavour.
I suppose keeping dependencies to a minimum is a reason to not merge it into main.
The text was updated successfully, but these errors were encountered: