Detached Head Detection Improvement #588
Merged
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge develop into main for zAppBuild 3.0.0 release
Release zAppBuild 3.0.1
Release zAppBuild 3.1.0
Release zAppBuild 3.2.0
Release zAppBuild 3.3.0
Release zAppBuild 3.4.0
Release zAppBuild 3.5.0
Release zAppBuild 3.6.0
Release zAppBuild 3.7.0
zAppBuild 3.7.0 version file update
Release zAppBuild 3.8.0
Release zAppBuild 3.9.0
Release zAppBuild 3.10.0
Release zAppBuild 3.10.1
Signed-off-by: Kai McGregor <[email protected]>
Signed-off-by: Kai McGregor <[email protected]>
Signed-off-by: Kai McGregor <[email protected]>
Signed-off-by: Kai McGregor <[email protected]>
Signed-off-by: Kai McGregor <[email protected]>
Signed-off-by: Kai McGregor <[email protected]>
Signed-off-by: Kai McGregor <[email protected]>
Signed-off-by: Kai McGregor <[email protected]>
Signed-off-by: Kai McGregor <[email protected]>
kmcgreg5
force-pushed
the
detached-head-performance-fix
branch
from
54ed716 to
a027e87
Compare
dennis-behm
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Thank you @kmcgreg5 . Looks good to me. Thanks for implementing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid overhead associated with
git status, changes git detached head detection to use thegit symbolic-refcommand. Head will be a reference to the branch if the repository is in a non-detached state, so the command will exit with a 0 RC. If the branch is in a detached state, HEAD will just contain the commit and not a reference. So the command will return a non-zero RC after failing to find a reference.The
-qoption suppresses error output from a detached state.This does change the return from false to true on an error scenario, in case that's important.
Resolves #587.