Voting on a proposal in the chat room does not update the UI immediately, which also allows for multiple votes

[tibetsprague]

No description provided.

[thomasgwatson]

I'm seeing that Reactions have these handlers

const onAddReaction = useCallback((post, emojiFull) => {
  const optimisticUpdate = { myReactions: [...post.myReactions, { emojiFull }], postReactions: [...post.postReactions, { emojiFull, user: { name: currentUser.name, id: currentUser.id } }] }
  const newPost = { ...post, ...optimisticUpdate }
  messageListRef.current?.data.map((item) => post.id === item.id || (post.localId && post.localId === item.localId) ? newPost : item)
}, [currentUser])

const onRemoveReaction = useCallback((post, emojiFull) => {
  const postReactions = post.postReactions.filter(reaction => {
    if (reaction.emojiFull === emojiFull && reaction.user.id === currentUser.id) return false
    return true
  })
  const newPost = { ...post, myReactions: post.myReactions.filter(react => react.emojiFull !== emojiFull), postReactions }
  messageListRef.current?.data.map((item) => post.id === item.id || (post.localId && post.localId === item.localId) ? newPost : item)
}, [currentUser])

Is this basically suggesting that we need to do specific manipulation of the virtuoso list to ensure that contents are re-rendered on votes?

@tibetsprague

[tibetsprague]

yes, see how we do it in onAddReaction in ChatRoom

[tibetsprague]

@thomasgwatson while you're at we should build in a safety check on the backend that only allows voting once per item