Apply some ruff fixes

Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>

Author: cyyever

label_studio/core/bulk_update_utils.py

@@ -166,7 +166,7 @@ def bulk_update(
                 cases=(case_template * len(placeholders[field])).format(*placeholders[field]),
                 type=_get_db_type(field, connection=connection),
             )
-            for field in parameters.keys()
+            for field in parameters
         )
 
         parameters = flatten(parameters.values(), types=list)

label_studio/core/label_config.py

@@ -227,8 +227,8 @@ def get_task_from_labeling_config(config):
             logger.debug(json.dumps(body, indent=2))
             dont_use_root = 'predictions' in body or 'annotations' in body
             task_data = body['data'] if 'data' in body else (None if dont_use_root else body)
-            predictions = body['predictions'] if 'predictions' in body else None
-            annotations = body['annotations'] if 'annotations' in body else None
+            predictions = body.get('predictions', None)
+            annotations = body.get('annotations', None)
     return task_data, annotations, predictions
 
 

label_studio/core/middleware.py

@@ -211,7 +211,7 @@ def process_request(self, request) -> None:
             return
 
         current_time = time.time()
-        last_login = request.session['last_login'] if 'last_login' in request.session else 0
+        last_login = request.session.get('last_login', 0)
 
         active_org = request.user.active_organization
         if active_org:

label_studio/core/settings/base.py

@@ -497,8 +497,7 @@
 UPLOAD_DIR = 'upload'
 AVATAR_PATH = 'avatars'
 
-SUPPORTED_EXTENSIONS = set(
-    [
+SUPPORTED_EXTENSIONS = {
         '.bmp',
         '.csv',
         '.flac',
@@ -521,8 +520,7 @@
         '.webm',
         '.webp',
         '.pdf',
-    ]
-)
+    }
 
 # directory for files created during unit tests
 TEST_DATA_ROOT = os.path.join(BASE_DATA_DIR, 'test_data')

label_studio/core/utils/params.py

@@ -78,7 +78,7 @@ def float_from_request(params, key, default):
         except ValueError:
             raise ValidationError({key: f'Incorrect value in key "{key}" = "{value}". It should be digit string.'})
     # float
-    elif isinstance(value, float) or isinstance(value, int):
+    elif isinstance(value, (float, int)):
         return float(value)
     # other
     else:
@@ -156,7 +156,7 @@ def get_env_list_int(key, default=None) -> Sequence[int]:
 
 def get_all_env_with_prefix(prefix=None, is_bool=True, default_value=None):
     out = {}
-    for key in os.environ.keys():
+    for key in os.environ:
         if not key.startswith(prefix):
             continue
         if is_bool:

label_studio/core/utils/static_serve.py

@@ -54,8 +54,7 @@ def serve(request, path, document_root=None, show_indexes=False, manifest_asset_
         manifest_asset_prefix = (
             f'/{manifest_asset_prefix}' if not manifest_asset_prefix.startswith('/') else manifest_asset_prefix
         )
-        if possible_asset.startswith(manifest_asset_prefix):
-            possible_asset = possible_asset[len(manifest_asset_prefix) :]
+        possible_asset = possible_asset.removeprefix(manifest_asset_prefix)
         fullpath = Path(safe_join(document_root, possible_asset))
     if not fullpath.exists():
         raise Http404(_('“%(path)s” does not exist') % {'path': fullpath})

label_studio/data_import/models.py

@@ -158,7 +158,7 @@ def read_tasks_list_from_json(self):
         if isinstance(tasks, dict):
             tasks = [tasks]
         tasks_formatted = []
-        for i, task in enumerate(tasks):
+        for task in tasks:
             if not task.get('data'):
                 task = {'data': task}
             if not isinstance(task['data'], dict):

label_studio/data_import/uploader.py

@@ -73,7 +73,7 @@ def create_file_upload(user, project, file):
     instance = FileUpload(user=user, project=project, file=file)
     if settings.SVG_SECURITY_CLEANUP:
         content_type, encoding = mimetypes.guess_type(str(instance.file.name))
-        if content_type in ['image/svg+xml']:
+        if content_type == 'image/svg+xml':
             clean_xml = allowlist_svg(instance.file.read().decode())
             instance.file.seek(0)
             instance.file.write(clean_xml.encode())

label_studio/data_manager/actions/basic.py

@@ -88,7 +88,7 @@ def delete_tasks_annotations(project, queryset, **kwargs):
         annotations = annotations.filter(completed_by=int(annotator_id))
 
     # take only tasks where annotations are going to be deleted
-    real_task_ids = set(list(annotations.values_list('task__id', flat=True)))
+    real_task_ids = set(annotations.values_list('task__id', flat=True))
     annotations_ids = list(annotations.values('id'))
     # remove deleted annotations from project.summary
     project.summary.remove_created_annotations_and_labels(annotations)
@@ -155,7 +155,7 @@ def delete_tasks_predictions(project, queryset, **kwargs):
     if flag_set('fflag_root_223_optimize_delete_predictions', organization=project.organization):
         real_task_ids = predictions.order_by().values_list('task_id', flat=True).distinct()
     else:
-        real_task_ids = set(list(predictions.values_list('task_id', flat=True)))
+        real_task_ids = set(predictions.values_list('task_id', flat=True))
 
     count = predictions.count()
     predictions.delete()

label_studio/data_manager/actions/cache_labels.py

@@ -53,7 +53,7 @@ def cache_labels_job(project, queryset, **kwargs):
             )
         # no counters
         else:
-            task.data[column_name] = ', '.join(sorted(list(set(task_labels))))
+            task.data[column_name] = ', '.join(sorted(set(task_labels)))
 
     Task.objects.bulk_update(tasks, fields=['data'], batch_size=1000)
     first_task = Task.objects.get(id=queryset.first().id)