SonarQube suggestions

Author: Hugo-CASTELL

src/main/java/n7/mcdalang/models/antlr/Languages.java

@@ -8,12 +8,12 @@ public enum Languages implements Serializable {
     ADA,
     ASSEMBLY,
     C,
-    CPlusPlus,
-    GO,
+    CPLUSPLUS,
     PYTHON,
     RUST,
     POWERSHELL,
-    JavaScript, RUBY;
+    JAVASCRIPT,
+    RUBY;
 
     @Override
     public String toString() {

src/main/java/n7/mcdalang/models/antlr/Translate.java

@@ -10,7 +10,9 @@
 import org.antlr.v4.runtime.tree.ParseTree;
 import org.antlr.v4.runtime.tree.ParseTreeWalker;
 
-public class Translate {
+public final class Translate {
+
+    private Translate() { }
 
     public static String translateToOther(String inputText, Languages languages) throws ParserErrorException {
         // Utiliser CharStreams au lieu de ANTLRInputStream
@@ -39,10 +41,10 @@ public static String translateToOther(String inputText, Languages languages) thr
             case PYTHON ->  translator = new McdalangToPython();
             case RUST ->  translator = new McdalangToRust();
             case RUBY ->  translator = new McdalangToRuby();
-            case CPlusPlus ->  translator = new McdalangToCPlusPlus();
-            case JavaScript ->  translator = new McdalangToJavaScript();
+            case CPLUSPLUS ->  translator = new McdalangToCPlusPlus();
+            case JAVASCRIPT ->  translator = new McdalangToJavaScript();
 
-            default -> new RuntimeException("Language not supported");
+            default -> throw new IllegalArgumentException("Language not supported");
         }
 
         walker.walk(translator, tree);

src/main/java/n7/mcdalang/models/antlr/listeners/OutputBaseListener.java

@@ -8,5 +8,5 @@ public abstract class OutputBaseListener extends McdalangBaseListener {
     // Retourne le code généré
     public String getCode(){
         return output.toString();
-    };
+    }
 }

src/main/java/n7/mcdalang/util/app/AppConfig.java

@@ -40,7 +40,7 @@ Fonts.CONSOLAS_BOLD, getURL("/fonts/ConsolasMono-Bold.ttf")
 
     public static final URL MCDABOT_HEAD_PATH = getURL("/images/mcdala_tete_grand.png");
     public static final Dimension DEFAULT_SIZE = new Dimension(1080, 720);
-    public static final List<Languages> DEFAULT_LANGUAGES = List.of(Languages.PYTHON, Languages.C, Languages.CPlusPlus, Languages.RUST, Languages.POWERSHELL, Languages.JAVA, Languages.JavaScript, Languages.ADA, Languages.RUBY);
+    public static final List<Languages> DEFAULT_LANGUAGES = List.of(Languages.PYTHON, Languages.C, Languages.CPLUSPLUS, Languages.RUST, Languages.POWERSHELL, Languages.JAVA, Languages.JAVASCRIPT, Languages.ADA, Languages.RUBY);
     public static final Themes DEFAULT_THEME = Themes.LIGHT;
     public static final boolean DEFAULT_AUTORUN_MODE = false;
     public static final int DEFAULT_FONT_SIZE = 12;

src/main/java/n7/mcdalang/util/exception/ParserErrorException.java

@@ -3,10 +3,10 @@
 import java.util.List;
 
 public class ParserErrorException extends RuntimeException {
-    private List<String> stack;
-    private Object offendingSymbol;
-    private int line;
-    private int charPositionInLine;
+    private final List<String> stack;
+    private final Object offendingSymbol;
+    private final int line;
+    private final int charPositionInLine;
 
     private int var;
 

src/main/java/n7/mcdalang/util/timer/Scheduler.java

@@ -1,11 +1,12 @@
 package n7.mcdalang.util.timer;
 
-import n7.mcdalang.util.app.AppConfig;
-
 import java.util.Timer;
 import java.util.TimerTask;
 
 public final class Scheduler {
+
+    private Scheduler() {}
+
     public static void runAfter(Runnable runnable, long delay) {
         new Timer().schedule(
                 new TimerTask() {

src/main/java/n7/mcdalang/views/McdaBotMainView.java

@@ -1,6 +1,5 @@
 package n7.mcdalang.views;
 
-import n7.mcdalang.controllers.MainController;
 import n7.mcdalang.views.components.mcdabot.MenuTab;
 
 import javax.swing.*;
@@ -35,11 +34,12 @@ public MenuTab getMenuTab(){
     //#region Public Methods
 
     public void show(JPanel tab) {
-        assert tab != null;
-        this.removeAll();
-        this.add(tab, BorderLayout.CENTER);
-        this.revalidate();
-        this.repaint();
+        if(tab != null) {
+            this.removeAll();
+            this.add(tab, BorderLayout.CENTER);
+            this.revalidate();
+            this.repaint();
+        }
     }
 
     //#region Public Methods

src/main/java/n7/mcdalang/views/components/util/CodeTextArea.java

@@ -79,7 +79,7 @@ public String getCode() {
 
     @Override
     public String getName() {
-        if (name == Languages.CPlusPlus) {
+        if (name == Languages.CPLUSPLUS) {
             return "C++";
         } else {
             return name.toString();

src/test/java/n7/mcdalang/TestGrammarToAda.java

@@ -5,7 +5,6 @@
 import n7.mcdalang.models.antlr.Translate;
 import org.junit.jupiter.api.Test;
 
-import java.io.IOException;
 import java.util.List;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;

src/test/java/n7/mcdalang/TestGrammarToC.java

@@ -123,7 +123,6 @@ void expressionsTest() {
         for(Pair<String, String> expression : expressions) {
             String input = "a " + expression.first + " b";
             String expected = "a " + expression.second + " b";
-            //expected = expected + ";";
             assertEquals(expected.strip(), superTest(input + "\n").strip());
         }