-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k6: pin go version to 1.23 #204322
base: master
Are you sure you want to change the base?
k6: pin go version to 1.23 #204322
Conversation
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
FYI, initial builds and tests with Go 1.24 in the found no issues with k6. |
@@ -14,7 +14,7 @@ class K6 < Formula | |||
sha256 cellar: :any_skip_relocation, x86_64_linux: "6c59c33536818d69e337bd36ce5b3e58054a019260d35027efae3b50ca7b56a5" | |||
end | |||
|
|||
depends_on "go" => :build | |||
depends_on "go@1.23" => :build # See https://github.com/grafana/k6/issues/2699 and https://github.com/grafana/k6/issues/2474 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Dependency '[email protected]' is an alias; use the canonical name 'go'.
this might need to wait after #201070
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not pin the latest version we need to pin to an old one if we want ?
@stefanb I am aware it will compile or that the test will pass - we have been running our tests with gotip for years. Even before the issue linked. The problem is that we weren't testing for this particular case and likely won't for the next case that breaks something. We just want that instead of us building with whatever is the latest go version we bump it when we bump it within k6. Currently, it seems that pinning to
@stefanb , @chenrui333 I don't know if you can help with any of this or point me to documentation about any of the approaches and reasons for the policies and linters. |
Fixing grafana/k6#2699
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?