Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

millie 2.1.2 #196865

Merged
merged 1 commit into from
Jan 1, 2025
Merged

millie 2.1.2 #196865

merged 1 commit into from
Jan 1, 2025

Conversation

leejongyoung
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@krehel
Copy link
Member

krehel commented Jan 1, 2025

Can you please provide additional context? This is a significant regression.

@krehel
Copy link
Member

krehel commented Jan 1, 2025

Ping @daeho-ro as I can't work the application due to language. Thanks!

@leejongyoung
Copy link
Contributor Author

Can you please provide additional context? This is a significant regression.

The livecheck block was removed because the manufacturer has restructured the version management of the bookshelf viewer application. Previously, updates were managed separately for each version. However, following redevelopment, all features and updates are now integrated into a single app. As a result, there is no longer a need to track individual versions, and the use of :latest with :no_check ensures the latest version is always installed.

@daeho-ro
Copy link
Member

daeho-ro commented Jan 1, 2025

Somehow the appcast.xml is not up to date and it seems that only used in beta phase. (until 2.0.22)

By this file, we can download a zip file of app package. But I cannot open it because macos says it contains some malicious code and so it it deleted automatically.

Now, the version is 2.1.2 and it does not call the appcast url. There is another url,

which is also pointing to the previous version.

For now, we may use :extract_plist for the livecheck until the next release and then I can check it later how the auto-update will be worked.

BTW, there is a versioned path, for example

so we can use the checksum laster when I figure out the livecheck method.

Casks/m/millie.rb Outdated Show resolved Hide resolved
Casks/m/millie.rb Outdated Show resolved Hide resolved
@daeho-ro
Copy link
Member

daeho-ro commented Jan 1, 2025

Another appcast.xml file in versioned path.

Maybe they locate it wrongly.

@leejongyoung
Copy link
Contributor Author

Another appcast.xml file in versioned path.

Maybe they locate it wrongly.

Thanks to your suggestion, I believe we can temporarily resolve the livecheck issue. However, it seems that the root appcast.xml is not being properly maintained. If this issue is resolved in the future, we can use a regex pattern from the URL to address the problem.

Casks/m/millie.rb Outdated Show resolved Hide resolved
Casks/m/millie.rb Outdated Show resolved Hide resolved
@khipp khipp added the livecheck Issues or PRs related to livecheck label Jan 1, 2025
@khipp khipp changed the title millie: update url millie 2.1.2 Jan 1, 2025
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the collaboration on this one everyone!

@p-linnane p-linnane merged commit f812de4 into Homebrew:master Jan 1, 2025
11 checks passed
@leejongyoung leejongyoung deleted the millie branch January 2, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extract_plist livecheck livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants