alot of reworking on both the portuguese (eu and br), spanish and english pages #1005
Conversation
_data/locales/en.yml
Outdated
| caskcreate: Making a cask is as simple as creating a formula. | ||
| install: | ||
| install: Install Homebrew | ||
| paste: Paste that in a macOS Terminal or Linux shell prompt. | ||
| what: The script explains what it will do and then pauses before it does it. Read about other <a href="https://docs.brew.sh/Installation">installation options</a>. | ||
| pkginstaller: If you're on macOS, try our new <code>.pkg</code> installer. | ||
| githubrelease: Download it from <a href="https://github.com/Homebrew/brew/releases/latest">Homebrew's latest GitHub release</a>. | ||
| githubrelease: Download it from the <a href="https://github.com/Homebrew/brew/releases/latest">"GitHub releases"</a> page. |
There was a problem hiding this comment.
But this doesn't link there, it links to the latest release
There was a problem hiding this comment.
I guess I can change up the link to make it link to the releases page or change up the text to convey it is the latest release, but from what I have seen, the French page also does this? I might try reversing the change but I don't know.
There was a problem hiding this comment.
I think the original text was better since it didn't require knowing about how releases are displayed in GitHub
_data/locales/en.yml
Outdated
| prefix: Homebrew won’t install files outside its prefix, but you can place a Homebrew installation wherever you want. | ||
| createpackages: You can trivially create your own Homebrew packages. | ||
| hack: After all, it’s just Git and Ruby underneath, you can easily hack away with the knowledge, revert your modifications, and merge upstream updates. | ||
| submit: And if you want, you can submit your package to us <a href="https://github.com/Homebrew/homebrew-core/pulls">here</a>! |
There was a problem hiding this comment.
This should link to the docs because casks exist too
There was a problem hiding this comment.
Yeah true, I'll get to doing that.
|
For some bits, I did attempt to translate it over (like the "you dont need to use the mouse" bit of |
*translate it over to the languages I mean, forgot to give more context |
Do you mean make it a different branch? |
|
Make it a different pull request, yes |
|
@SMillerDev I have made it a different branch. |
_data/locales/pt.yml
Outdated
| @@ -1,5 +1,5 @@ | |||
| pt: | |||
| locale_name: Português | |||
| locale_name: Português (europeu) | |||
There was a problem hiding this comment.
| locale_name: Português (europeu) | |
| locale_name: Português |
is more typical, no?
_layouts/index.html
Outdated
| @@ -101,7 +101,6 @@ <h2 id="question">{{ t.pagecontent.question }}</h2> | |||
| </div> | |||
| </div> | |||
| </li> | |||
|
|
|||
_data/locales/en.yml
Outdated
| prefix: Homebrew won’t install files outside its prefix and you can place a Homebrew installation wherever you like. | ||
| createpackages: Trivially create your own Homebrew packages. | ||
| hack: It’s all Git and Ruby underneath, so hack away with the knowledge that you can easily revert your modifications and merge upstream updates. | ||
| prefix: Homebrew won’t install files outside its prefix, but you can place a Homebrew installation wherever you want. | ||
| createpackages: You can trivially create your own Homebrew packages. | ||
| hack: It’s just Git and Ruby underneath, you can hack away with the knowledge, easily revert your modifications, and merge upstream updates. | ||
| formula: "Homebrew formulae are simple Ruby scripts:" | ||
| editor: opens in $EDITOR! | ||
| editor: open it in $EDITOR! | ||
| complement: Homebrew complements macOS (or your Linux system). Install your RubyGems with <code>gem</code> and their dependencies with <code>brew</code>. | ||
| caskinstall: '“To install, drag this icon…” no more. <a href="https://formulae.brew.sh/cask/">Homebrew Cask</a> installs macOS apps, fonts and plugins and other non-open source software.' | ||
| caskinstall: '“To install, drag the icon…” not anymore, as <a href="https://formulae.brew.sh/cask/">Homebrew Casks</a> can install macOS apps, fonts and plugins and other non-open source software.' |
There was a problem hiding this comment.
Please leave the English wording as-is, thanks, or open a dedicated PR to discuss
|
Sorry about the changes, did not know English was not meant to be changed. I'll sync over the fork and make the changes to the Portuguese and Spanish pages. |
What did I do?
I made some slightly significant changes to the 4 pages above. You can see this in the
caskinstall,pkginstaller, andgithubreleasesections as the French version ofgithubreleasesounded a lot better than the English, and the Portuguese (EU & BR) and Spanish pages (which I based off of the English version), also better conjugation in some areas.I also added a little section in the index.html called
submit, right now I only made the English version but I might consider adding it to pt and es.I think this really should be checked a lot more than my previous commits in case they sound too overenthusiastic, or poorly worded, or both, but I think they all sound pretty good.