diff --git a/Jenkinsfile b/Jenkinsfile index 48d0c8c2fc84..9c0d9bf31b0b 100644 --- a/Jenkinsfile +++ b/Jenkinsfile @@ -44,6 +44,7 @@ pipeline { paths+=(`find plugins/engine-configuration/ui/target | grep -E "pdi-engine-configuration-ui-$dist(-sources)?\\.jar"`) paths+=(`find plugins/file-open-save/core/target | grep -E "file-open-save-core-$dist(-sources)?\\.jar"`) paths+=(`find plugins/get-fields/core/target | grep -E "get-fields-core-$dist(-sources)?\\.jar"`) + paths+=(`find plugins/connections/ui/target | grep -E "connections-ui-$dist(-sources)?\\.jar"`) for path in ${paths[@]} do diff --git a/plugins/connections/pom.xml b/plugins/connections/pom.xml index b95aee333e5e..b7165307db9b 100644 --- a/plugins/connections/pom.xml +++ b/plugins/connections/pom.xml @@ -34,6 +34,7 @@ 3.0.13 2.0.10 0.1.8 + 1.9.2 1.5.6 4.6 3.0.1 diff --git a/plugins/connections/ui/src/main/java/org/pentaho/di/connections/ui/dialog/ConnectionDialog.java b/plugins/connections/ui/src/main/java/org/pentaho/di/connections/ui/dialog/ConnectionDialog.java index 0adc70253380..2bb9852cf9ea 100644 --- a/plugins/connections/ui/src/main/java/org/pentaho/di/connections/ui/dialog/ConnectionDialog.java +++ b/plugins/connections/ui/src/main/java/org/pentaho/di/connections/ui/dialog/ConnectionDialog.java @@ -41,7 +41,6 @@ */ public class ConnectionDialog extends ThinDialog { - private static final Image LOGO = GUIResource.getInstance().getImageLogoSmall(); private static final String OSGI_SERVICE_PORT = "OSGI_SERVICE_PORT"; private static final int OPTIONS = SWT.APPLICATION_MODAL | SWT.DIALOG_TRIM | SWT.RESIZE | SWT.MAX; private static final String THIN_CLIENT_HOST = "THIN_CLIENT_HOST"; @@ -68,7 +67,7 @@ public void open( String title, String connectionName ) { clientPath.append( "#/intro" ); } super.createDialog( title, getRepoURL( clientPath.toString() ), - OPTIONS, LOGO ); + OPTIONS, GUIResource.getInstance().getImageLogoSmall() ); super.dialog.setMinimumSize( 545, 458 ); new BrowserFunction( browser, "close" ) { @@ -131,7 +130,7 @@ private static String getRepoURL( String path ) { host = LOCALHOST; port = getOsgiServicePort(); } - return "http://" + host + ":" + port + path; + return System.getProperty( "KETTLE_CONTEXT_PATH" ) + "/osgi" + path; } private static String getKettleProperty( String propertyName ) { diff --git a/plugins/connections/ui/src/main/java/org/pentaho/di/connections/ui/tree/ConnectionPopupMenuExtension.java b/plugins/connections/ui/src/main/java/org/pentaho/di/connections/ui/tree/ConnectionPopupMenuExtension.java index 58af5a88a580..b831464e4df9 100644 --- a/plugins/connections/ui/src/main/java/org/pentaho/di/connections/ui/tree/ConnectionPopupMenuExtension.java +++ b/plugins/connections/ui/src/main/java/org/pentaho/di/connections/ui/tree/ConnectionPopupMenuExtension.java @@ -50,8 +50,6 @@ public class ConnectionPopupMenuExtension implements ExtensionPointInterface { private static final Class PKG = ConnectionPopupMenuExtension.class; private Supplier spoonSupplier = Spoon::getInstance; - private Menu rootMenu; - private Menu itemMenu; private ConnectionDelegate vfsConnectionDelegate; private ConnectionTreeItem vfsConnectionTreeItem; @@ -83,8 +81,7 @@ public ConnectionPopupMenuExtension( ConnectionDelegate connectionDelegate ) { } private Menu createRootPopupMenu( Tree tree ) { - if ( rootMenu == null ) { - rootMenu = new Menu( tree ); + Menu rootMenu = new Menu( tree ); MenuItem menuItem = new MenuItem( rootMenu, SWT.NONE ); menuItem.setText( BaseMessages.getString( PKG, "VFSConnectionPopupMenuExtension.MenuItem.New" ) ); menuItem.addSelectionListener( new SelectionAdapter() { @@ -93,13 +90,11 @@ public void widgetSelected( SelectionEvent selectionEvent ) { vfsConnectionDelegate.openDialog(); } } ); - } return rootMenu; } private Menu createItemPopupMenu( Tree tree ) { - if ( itemMenu == null ) { - itemMenu = new Menu( tree ); + Menu itemMenu = new Menu( tree ); MenuItem editMenuItem = new MenuItem( itemMenu, SWT.NONE ); editMenuItem.setText( BaseMessages.getString( PKG, "VFSConnectionPopupMenuExtension.MenuItem.Edit" ) ); editMenuItem.addSelectionListener( new SelectionAdapter() { @@ -115,7 +110,6 @@ private Menu createItemPopupMenu( Tree tree ) { vfsConnectionDelegate.delete( vfsConnectionTreeItem.getLabel() ); } } ); - } return itemMenu; } } diff --git a/plugins/connections/ui/src/main/resources-filtered/app/index.html b/plugins/connections/ui/src/main/resources-filtered/app/index.html index e3a7d7b9c593..9b819c772b71 100644 --- a/plugins/connections/ui/src/main/resources-filtered/app/index.html +++ b/plugins/connections/ui/src/main/resources-filtered/app/index.html @@ -6,8 +6,8 @@ VFS Connection Dialog - - + +