Fix tag visiblity toggle

Author: Hexer10

addons/sourcemod/scripting/hextags.sp

@@ -51,7 +51,7 @@ Handle fTagsUpdated;
 Handle fMessageProcess;
 Handle fMessageProcessed;
 Handle fMessagePreProcess;
-Handle g_hPref_HideTags;
+Handle hVibilityCookie;
 
 DataPack dataOrder;
 
@@ -133,7 +133,7 @@ public void OnPluginStart()
 	if (!HookEventEx("round_end", Event_RoundEnd))
 		LogError("Failed to hook \"round_end\", \"sm_hextags_roundend\" won't produce any effect.");
 
-	g_hPref_HideTags = RegClientCookie("Hextags_Visability", "Show or hide the tags.", CookieAccess_Private);
+	hVibilityCookie = RegClientCookie("HexTags_Visibility", "Show or hide the tags.", CookieAccess_Private);
 
 #if defined DEBUG
 	RegConsoleCmd("sm_gettagvars", Cmd_GetVars);
@@ -155,27 +155,18 @@ public void OnAllPluginsLoaded()
 	bSteamWorks = LibraryExists("SteamWorks");
 
 	LoadKv();
-	if (bLate) for (int i = 1; i <= MaxClients; i++)if (IsClientInGame(i))OnClientPostAdminCheck(i);
+	if (bLate) for (int i = 1; i <= MaxClients; i++)if (IsClientInGame(i)) 
+	{
+		if (!AreClientCookiesCached(i))
+			OnClientCookiesCached(i);
+		OnClientPostAdminCheck(i);
+	}
 
 	//Timers
 	if (bCSGO)
 		CreateTimer(5.0, Timer_ForceTag, _, TIMER_REPEAT);
 }
 
-public void OnClientCookiesCached(int client)
-{
-	char sValue[8];
-	GetClientCookie(client, g_hPref_HideTags, sValue, sizeof(sValue));
-	
-	if (strlen(sValue) == 0)
-	{
-		strcopy(sValue, sizeof(sValue), "1");
-		SetClientCookie(client, g_hPref_HideTags, "1");
-	}
-	
-	bHideTag[client] = (sValue[0] != '\0' && StringToInt(sValue));
-}
-
 public void OnLibraryAdded(const char[] name)
 {
 	Debug_Print("Called OnLibraryAdded %s", name);
@@ -340,7 +331,7 @@ public Action Cmd_ToggleTags(int client, int args)
 		ReplyToCommand(client, "[SM] Your tags are no longer visible.");
 	}
 
-	SetClientCookie(client, g_hPref_HideTags, bHideTag[client] ? "1" : "0");
+	SetClientCookie(client, hVibilityCookie, bHideTag[client] ? "0" : "1");
 }
 
 public Action Cmd_GetTeam(int client, int args)
@@ -368,6 +359,14 @@ public void OnClientPostAdminCheck(int client)
 	LoadTags(client);
 }
 
+public void OnClientCookiesCached(int client)
+{
+	char sValue[8];
+	GetClientCookie(client, hVibilityCookie, sValue, sizeof(sValue));
+	
+	bHideTag[client] = sValue[0] == '\0' ? false : !StringToInt(sValue);
+}
+
 public Action RankMe_OnPlayerLoaded(int client)
 {
 	RankMe_GetRank(client, RankMe_LoadTags);
@@ -396,7 +395,6 @@ public Action RankMe_LoadTags(int client, int rank, any data)
 		ReplaceString(sTags[client][ScoreTag], sizeof(sTags[][]), "{rmRank}", sRank);
 		CS_SetClientClanTag(client, sTags[client][ScoreTag]); //Instantly load the score-tag
 	}
-	
 }
 
 public Action CP_OnChatMessage(int& author, ArrayList recipients, char[] flagstring, char[] name, char[] message, bool& processcolors, bool& removecolors)