Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests for Poseidon hashing, both on rust and ts accumulator #41

Closed
maaasyn opened this issue Jan 5, 2024 · 1 comment
Closed
Assignees

Comments

@maaasyn
Copy link
Collaborator

maaasyn commented Jan 5, 2024

  • It's absolutly crusial for our hasher to give the same hashes for the same values on TS-accumulator and RUST-accumulatr. I've done some unit tests on ts-accumulator for keccak: https://github.com/HerodotusDev/accumulators/pull/72/files and I've done same tests for keccak on rust dev -> main hashes alignment with ts accumulators for keccak #40.

  • We still need to test the building of trees with poseidon. The test I would like to see should be done both on ts accumulator and rust accumulator. We can copy paste the test scenarious which I done for keccak, but replace the hashes for the new one. The ts-accumulator detereminates what is consider valid hash.

@rkdud007 rkdud007 self-assigned this Jan 5, 2024
@rkdud007
Copy link
Member

close with #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants