Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacked MMR #13

Merged
merged 16 commits into from
Nov 9, 2023
Merged

Stacked MMR #13

merged 16 commits into from
Nov 9, 2023

Conversation

beeinger
Copy link
Member

@beeinger beeinger commented Nov 8, 2023

No description provided.

@beeinger beeinger changed the title Feat/infinitely stackable mmr Infinitely Stackable MMR Nov 8, 2023
@beeinger beeinger linked an issue Nov 8, 2023 that may be closed by this pull request
store: Rc<S>,
key: String,
pub struct InStoreCounter {
pub store: Rc<dyn Store>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I check you change code from Rc<S> to Rc<dyn Store> . Which is from static dispatch to dynamic dispatch. I usually using dynamic dispatch only when it's cannot be determine during compile time ( because dynamic dispatch determine type during run time it takes more time ). In our case we can determine to have one store type per each mmr, is there any specific reason why you changed into dynamic dispatch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the store is dynamic because I want the flexibility in infinitely stackable mmr to provide any stores for any mmr

And also it's just a reference to the dyn Store it's not storing the store itself

@beeinger beeinger marked this pull request as ready for review November 9, 2023 17:14
@beeinger beeinger changed the title Infinitely Stackable MMR Stacked MMR Nov 9, 2023
@beeinger beeinger merged commit db5303f into develop Nov 9, 2023
@beeinger beeinger deleted the feat/infinitely_stackable_mmr branch November 9, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinitely Stackable MMR
2 participants