Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type checking in CI #104

Open
3 of 7 tasks
AndyRae opened this issue Feb 25, 2025 · 0 comments · May be fixed by #119
Open
3 of 7 tasks

Type checking in CI #104

AndyRae opened this issue Feb 25, 2025 · 0 comments · May be fixed by #119
Assignees
Milestone

Comments

@AndyRae
Copy link
Member

AndyRae commented Feb 25, 2025

Is this the right issue type?

  • Yes, I'm planning work for this project team.

Summary

To create consistent code - it would preferable to have MyPy running in CI as a check.

Currently this would fail as the codebase has plenty of errors in typing...! These are gradually being fixed, but might be at the point it could be captured in one shot.

Acceptance Criteria

  • MyPy check runs on CI
  • Code passes type checking
  • Tests pass.

Tasks

  • New workflow for type checking
  • Fix any typing issues

Confirm creation

  • This issue is ready
@github-project-automation github-project-automation bot moved this to MoreInfo in Hutch Backlog Feb 25, 2025
@AndyRae AndyRae moved this from MoreInfo to Ready in Hutch Backlog Feb 25, 2025
@AndyRae AndyRae added this to the v1.0.0 milestone Feb 25, 2025
@AndyRae AndyRae linked a pull request Mar 8, 2025 that will close this issue
2 tasks
@AndyRae AndyRae moved this from Ready to In Progress in Hutch Backlog Mar 8, 2025
@AndyRae AndyRae self-assigned this Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant