Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Styling Props Transient #442

Open
xavierdonnellon opened this issue Jun 27, 2023 · 0 comments
Open

Make Styling Props Transient #442

xavierdonnellon opened this issue Jun 27, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@xavierdonnellon
Copy link
Contributor

Rather than pass in normal props to styled subcomponent types, use transient props for styling that get consumed at the style level and don't get added to the html elements in the DOM.

Directly adding non-transient props as attributes on HTML elements can lead to console errors.

See the documentation:
StyledComponents docs
@xavierdonnellon xavierdonnellon added the enhancement New feature or request label Jun 27, 2023
@aVileBroker aVileBroker moved this to Todo in Foundry-React-UI Jul 10, 2023
@aVileBroker aVileBroker removed the status in Foundry-React-UI Jul 18, 2023
@aVileBroker aVileBroker moved this to Todo in Foundry-React-UI Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Foundry-React-UI
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xavierdonnellon