Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown | Add iconPrefix and iconSuffix to OptionsProps (OptionItems), and export UsefulDropdownState #440

Open
aVileBroker opened this issue Jun 22, 2023 · 0 comments
Open

Dropdown | Add iconPrefix and iconSuffix to OptionsProps (OptionItems), and export UsefulDropdownState #440

aVileBroker opened this issue Jun 22, 2023 · 0 comments
Labels
0.5 Story Points issue size: .5 enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@aVileBroker
Copy link
Contributor

aVileBroker commented Jun 22, 2023 •
edited
Loading

Currently the only way to get icons in the dropdown is to override the checkmark container and do some really hacky tricks.

It would also make doing styling easier if UsefulDropdownState was added to every style-able subcomponent (and options were passed id and optionValue)

AC:

  • Add iconPrefix/iconSuffix to OptionsProps
  • Change the StyledBaseSpan in the OptionItem to be a Text component
  • Pass iconPrefix and iconSuffix to the Text component
  • Add OptionItemText as a restyle-able/prop-able/ref-able subcomponent that is exported on the Dropdown
  • Pass OptionItem and OptionItemText the id and optionValue of their option
  • Export UsefulDropdownState in index.tsx
@aVileBroker aVileBroker added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed 0.5 Story Points issue size: .5 labels Jun 22, 2023
@aVileBroker aVileBroker changed the title Dropdown | Add iconPrefix and Suffix to OptionsProps (OptionItems), and export UsefullDropdownState Dropdown | Add iconPrefix and iconSuffix to OptionsProps (OptionItems), and export UsefullDropdownState Jun 22, 2023
@aVileBroker aVileBroker changed the title Dropdown | Add iconPrefix and iconSuffix to OptionsProps (OptionItems), and export UsefullDropdownState Dropdown | Add iconPrefix and iconSuffix to OptionsProps (OptionItems), and export UsefulDropdownState Jun 22, 2023
@aVileBroker aVileBroker moved this to Todo in Foundry-React-UI Jun 22, 2023
j-leidy added a commit to j-leidy/foundry-ui that referenced this issue Jul 12, 2023
@j-leidy
refactor(dropdown.tsx): added search input and container props moved …
f1d3d15 
…input out of valueitem

Headstorm#440
@aVileBroker aVileBroker removed the status in Foundry-React-UI Jul 18, 2023
@aVileBroker aVileBroker moved this to Todo in Foundry-React-UI Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.5 Story Points issue size: .5 enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Foundry-React-UI
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aVileBroker