Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LRU cache for TOI response #37

Open
r4mmer opened this issue Nov 26, 2021 · 0 comments
Open

LRU cache for TOI response #37

r4mmer opened this issue Nov 26, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@r4mmer
Copy link
Member

r4mmer commented Nov 26, 2021

Summary

If we could cache which addresses and transactions the toi have responded as banned we would be able to refuse any tx with these addresses or transactions without asking the toi service again.
This would be even more useful in the event of a downtime (or any other problem) of the toi service, we could still safely refuse transactions based on previous responses from the toi.

A problem with this approach is that the api used does not indicate which addresses/transactions were banned, only that there were at least 1 banned address or transaction on the list passed to the api.

To make a LRU cache possible we would need to change this behavior on the api or implement another api for this (i.e. once the existence of the banned resource is confirmed, ask another api to see which one).

@r4mmer r4mmer added the enhancement New feature or request label Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant