Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: move handler role to serverless yml #257

Open
tuliomir opened this issue Jul 28, 2022 · 0 comments
Open

Refactor: move handler role to serverless yml #257

tuliomir opened this issue Jul 28, 2022 · 0 comments
Labels

Comments

@tuliomir
Copy link
Contributor

tuliomir commented Jul 28, 2022

It is possible to use the serverless-iam-roles-per-function plugin, added on #235, to automatically generate the loadWalletApi roles that are manually defined on AWS itself at the moment.

tuliomir added a commit that referenced this issue Jul 28, 2022
A new issue was created to replace this comment
Refs: #257
tuliomir added a commit that referenced this issue Jul 28, 2022
* feat: implements draft for getting token metadata

* feat: implements draft for updating token metadata

* refactor: s3 manipulation assumed to take place at explorer service

* docs: improves jsdocs on new feature

* feat: gets token metadata from environment variable

* style: linter fix after rebase

* feat: adds api-key to update metadata request

* fix: uses latest nft tx validation method from the lib

* test: implements tests for the TxProcessor NFT validation

* style: fixes lint errors

* refactor: moves nft validation logic from http to lambdas

* refactor: removes unnecessary update s3 api key

* feat: error handling on metadata update

* refactor: moves MAX_METADATA_UPDATE_RETRIES to env

* refactor: moves nftUid str on failure to handler

* refactor: adapts tests to use new file structure

* refactor: use lodash to clone sample objs

* style: fixes lint errors

* chore: package-lock.json update

* fix: sets same bitcore-lib version as the wallet-lib

* chore: updating dependencies after wallet-lib

* refactor: improves testability of the nft utils

* test: basic testing onNewNftEvent handler

* test: unit testing nftUtils

* test: unit testing nftUtils: token metadata gen

* test: unit testing nftUtils: getTokenMetadata

* test: placeholder skipped _updateMetadata tests

* refactor: update explorer-service lambda name

* chore: new jest command detecting open handles

* test: nft validation failure

* test: unmocked nft validation

* refactor: lambda call with json instead of str

* refactor: throw when TOKEN_METADATA_URL is empty

* test: working lambda mocking test

* test: updateMetadata retry feature

* test: updateMetadata retry feature

* fix: onNewNftEvent event body format

* refactor: token metadata url is enforced on env

* fix: adds new env variable to readme, serverless

* fix: event object format

* fix: getTokenMetadata error handling

* chore: update the create_or_update lambda name

* ci: adds new env variable to workflow

* fix: onNewNftEvent signature and tests

* test: invokeNftHandlerLambda unit tests

* test: event helper unit tests

* feat: mapping wallet and explorer services stages

* feat: improves error handling

* ci: fix token metadata url on dev

* docs: nftCreationTx docs

* style: fix typo

* fix: warmer conflict

* fix: handler invoke error handling

* refactor: adapt to the new explorer contract

* refactor: adapt tests to the new explorer contract

* fix: insert onNewNftEvent again

* feat: dynamic roles for lambda invokes

* chore: reminder on serverless.yml

* refactor: removes obsolete env variables

* revert: testing script

* refactor: obsolete dependency

* docs: improves docstrings

* perf: improves error handling message

* refactor: minor fixes and code cleanup

* refactor: inlines onNewNftEvent types

* feat: adds debug data to failures

* refactor: moves lambda endpoints to environment

* refactor: improves error handling on txProcessor

* chore: removes todo

A new issue was created to replace this comment
Refs: #257

* refactor: improves arn fetching syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant