Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic PR to master in the release process #436

Open
r4mmer opened this issue May 9, 2024 · 2 comments
Open

Automatic PR to master in the release process #436

r4mmer opened this issue May 9, 2024 · 2 comments

Comments

@r4mmer
Copy link
Member

r4mmer commented May 9, 2024

Motivation

During the release process, changes made on the release-candidate and release branches should be merged back into master.
This is meant to create a common history in the git DAG and prevent conflicts between these branches.

This step of the release process is being often overlooked, which makes the next release start by merging any changes made in the release branch back to master.
To make this easier and less likely to happen we can just create a PR to merge from release-candidate or release back to master automatically.

How

We run a workflow to build the docker container when a tag vX.X.X or vX.X.X-rc.X is pushed, we can add a step in this workflow to create a PR merging the release (in case of vX.X.X) or release-candidate (in case of vX.X.X-rc.X) to master.

This can be achieved by using the github cli available, the command gh pr create (docs) can easily create the PR, assign the user that signed the tag, add it to the "Hathor Network" project and add a title and body that makes sense for the PR.

@tuliomir
Copy link
Contributor

tuliomir commented May 9, 2024

Another good workflow candidate is the apidocs-upload.yml, that also interacts with version labels.

@pedroferreira1
Copy link
Member

I like the proposal and it's really important for us right now, given the previous mistakes we've made. I like the approach of creating this automatic PR and adding to our projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants