Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop confirming outputs before parsing them #70

Merged
merged 8 commits into from
Oct 3, 2024
Merged

fix: stop confirming outputs before parsing them #70

merged 8 commits into from
Oct 3, 2024

Conversation

r4mmer
Copy link
Member

@r4mmer r4mmer commented May 22, 2024

Acceptance criteria

Solve issue #68

@r4mmer r4mmer requested a review from pedroferreira1 May 22, 2024 21:32
@r4mmer r4mmer self-assigned this May 22, 2024
@r4mmer r4mmer linked an issue May 22, 2024 that may be closed by this pull request
Change outputs are confirmed without being received #68
Open
r4mmer
r4mmer commented May 22, 2024
View reviewed changes
@r4mmer r4mmer linked an issue May 23, 2024 that may be closed by this pull request
Change output list should be verified to avoid breaking the UI #69
Open
@r4mmer r4mmer requested a review from tuliomir May 23, 2024 13:35
tuliomir
tuliomir approved these changes May 27, 2024
View reviewed changes
pedroferreira1
pedroferreira1 approved these changes Sep 26, 2024
View reviewed changes
r4mmer added 4 commits October 2, 2024 14:02
@r4mmer
Merge remote-tracking branch 'origin/dev' into fix/change-confirmation
7d0b5ea 
* origin/dev:
  chore: update linter version
  chore: update CI (#77)
  feat: use correct size limit
  fix: code scanning
  [auto] Add guideline enforcer
  [auto] Add manifest
  [auto]: add PR template
@r4mmer
chore: move initial check outside the loop
fc2d2d3
@r4mmer
fix: change list check (#71)
0445f6c 
* fix: throw only if global context is cleaned in sign_tx

* chore: linter changes

* test: generate change index inside output indexes

* feat: check for change index outside output array

* chore: docstring update
@r4mmer
Merge branch 'dev' into fix/change-confirmation
563466a
@r4mmer r4mmer requested a review from pedroferreira1 October 3, 2024 15:41
@r4mmer r4mmer merged commit 9f3478d into dev Oct 3, 2024
23 checks passed
@r4mmer r4mmer deleted the fix/change-confirmation branch October 3, 2024 16:14
r4mmer added a commit that referenced this pull request Oct 3, 2024
@r4mmer
Merge remote-tracking branch 'origin/dev' into feat/ledger-admin-meth…
7068697 
…od-01

* origin/dev:
  fix: stop confirming outputs before parsing them (#70)
  chore: changelog updates and utils (#72)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuliomir tuliomir tuliomir approved these changes

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

Assignees

@r4mmer r4mmer

Labels
None yet
Projects
Hathor Network
Status: Waiting to be deployed
Milestone
No milestone
3 participants
@r4mmer @tuliomir @pedroferreira1