lint fixes for travis tests

Author: Manny Henri

package.json

@@ -47,6 +47,13 @@
       "prefer-template": 2,
       "no-use-before-define": 0,
       "newline-per-chained-call": 0,
+      "import/no-dynamic-require": 0,
+      "prefer-destructuring": ["error", {
+        "array": false,
+        "object": true
+      }, {
+        "enforceForRenamedProperties": false
+      }],
       "arrow-body-style": [
         2,
         "as-needed"

src/commands/generate.js

@@ -12,15 +12,15 @@ program
  * Generate string output for a single blueprint
  * @param blueprint
  */
-const printBlueprint = blueprint => {
+const printBlueprint = (blueprint) => {
     console.log(`    ${chalk.yellow(blueprint.name)} - ${blueprint.description}`);
     console.log(`    Usage: ${blueprint.usage}`);
     console.log('');
 };
 
 program.on('--help', () => {
     // Get available blueprints from the current mern project
-    const blueprints = getMernConfig().blueprints;
+    const { blueprints } = getMernConfig().blueprints;
     console.log(chalk.yellow('Available Generators'));
     console.log(chalk.yellow('____________________'));
     console.log('');

src/commands/main-init.js

@@ -3,6 +3,7 @@ import chalk from 'chalk';
 import elegantSpinner from 'elegant-spinner';
 import logUpdate from 'log-update';
 import variants from '../../variants.json';
+
 require('shelljs/global');
 
 const frame = elegantSpinner();
@@ -58,4 +59,3 @@ exec(`git pull ${selectedVariant.git} ${selectedVariant['git-branch']}`, (code)
     exec('npm install');
     console.log(chalk.green.bold(`Installing dependencies for ${program.args[0]} completed.....You are good to go!`));
 });
-

src/commands/main-list.js

@@ -11,7 +11,7 @@ const variantsTable = new Table({
 });
 
 // Make a variants table to show to all the variants
-variantsTable.push(...variants.map(v => Object.keys(v).map((k) => v[k]).slice(0, 3)));
+variantsTable.push(...variants.map(v => Object.keys(v).map(k => v[k]).slice(0, 3)));
 
 console.log(chalk.yellow('MERN Variants'));
 console.log(chalk.yellow('-------------'));

src/commands/main-search.js

@@ -22,7 +22,7 @@ const variantsTable = new Table({
 const filteredVariants = variants.filter(variant => variant.name.toLowerCase().search(input.toLowerCase()) !== -1 || variant.description.toLowerCase().search(input.toLowerCase()) !== -1);
 
 // Make a variants table to show to all the variants matched with the given search string
-variantsTable.push(...filteredVariants.map(v => Object.keys(v).map((k) => v[k]).slice(0, 3)));
+variantsTable.push(...filteredVariants.map(v => Object.keys(v).map(k => v[k]).slice(0, 3)));
 
 console.log(chalk.yellow(`Search results for ${input}`));
 console.log(chalk.yellow('-------------'));

src/tasks/generate.js

@@ -16,7 +16,7 @@ class generate {
      * Process the given arguments to render the target path and the target boilerplate
      * @param args
      */
-    processArgs = args => {
+    processArgs = (args) => {
         if (args.length < 2) {
             this.ui.writeError('Please pass relevant number of arguments');
             process.exit(1);
@@ -53,8 +53,8 @@ class generate {
      * Write the generated string to the target path
      * @param target
      */
-    writeTarget = target => {
-        writeFile(`${process.cwd()}/${target['target-path']}`, target.renderedTemplate, err => {
+    writeTarget = (target) => {
+        writeFile(`${process.cwd()}/${target['target-path']}`, target.renderedTemplate, (err) => {
             if (err) {
                 this.ui.writeError(err);
                 exit(1);

src/tasks/getMernConfig.js

@@ -5,7 +5,7 @@ import chalk from 'chalk';
  * @param config
  * @returns {boolean}
  */
-const validateMernConfig = config => {
+const validateMernConfig = (config) => {
     let valid = true;
     const requiredKeys = ['blueprints'];
     const requiredBlueprintKeys = ['name', 'description', 'usage', 'files'];
@@ -15,17 +15,15 @@ const validateMernConfig = config => {
         return false;
     }
 
-    config.blueprints.forEach(b => {
+    config.blueprints.forEach((b) => {
         if (!requiredBlueprintKeys.every(c => c in b)) {
             valid = false;
-        } else {
-            if (b.files) {
-                b.files.forEach(file => {
-                    if (!requiredFileKeys.every(c => c in file)) {
-                        valid = false;
-                    }
-                });
-            }
+        } else if (b.files) {
+            b.files.forEach((file) => {
+                if (!requiredFileKeys.every(c => c in file)) {
+                    valid = false;
+                }
+            });
         }
     });
 

src/tasks/renderTargetPath.js

@@ -1,5 +1,6 @@
 import ejs from 'ejs';
 import helpers from '../util/ejsHelpers';
+
 require('shelljs/global');
 
 /**

src/util/fileExists.js

@@ -5,7 +5,7 @@ import fs from 'fs';
  * @param path
  * @returns {boolean}
  */
-export default path => {
+export default (path) => {
     try {
         fs.accessSync(path, fs.F_OK);
         return true;

src/util/ui.js

@@ -1,7 +1,8 @@
 import chalk from 'chalk';
-const DEFAULT_WRITE_LEVEL = 'INFO';
 import { EOL } from 'os';
 
+const DEFAULT_WRITE_LEVEL = 'INFO';
+
 /**
  * Helper class to write debug output to console
  */

tests/main-test.js

@@ -5,7 +5,7 @@ import pify from 'pify';
 const exec = pify(childProcess.exec);
 
 
-test('shows help on --help', async t => {
+test('shows help on --help', async (t) => {
     const stdout = await exec('../bin/mern.js --help');
     t.is(stdout.trim(), `Usage: mern [options] [command]
 
@@ -28,7 +28,7 @@ test('shows help on --help', async t => {
 });
 
 
-test('shows help on --h', async t => {
+test('shows help on --h', async (t) => {
     const stdout = await exec('../bin/mern.js --help');
     t.is(stdout.trim(), `Usage: mern [options] [command]