Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page weight formatting #13

Closed
sarahfossheim opened this issue Nov 27, 2023 · 2 comments
Closed

Page weight formatting #13

sarahfossheim opened this issue Nov 27, 2023 · 2 comments
Assignees

Comments

@sarahfossheim
Copy link

@maceto could you format the data the same as the other endpoints?

Current behavior

Currently it returns the data the same as in the JSON files:

[{
  "date": "2023-07-01",
  "technology": "WordPress",
  "rank": "ALL",
  "geo": "ALL",
  "client": "desktop",
  "median_bytes_total": "2600099",
  "median_bytes_js": "652651",
  "median_bytes_image": "1048110"
}]

Desired behavior

Something similar to the other endpoints, see for example: #4

Example format:

[{
  "date": "2023-07-01",
  "technology": "WordPress",
  "rank": "ALL",
  "geo": "ALL",
  "pageWeight": [{ // Or "page-weight"
    "name": "total", // Total, JS, Image
    "mobile": {
        "median_bytes": 1234
    },
    "desktop": {
        "median_bytes": 567
    },
  }]
}]
@maceto
Copy link
Collaborator

maceto commented Nov 28, 2023

Hello @sarahfossheim

I will work on this with @rviscomi I think the BQ query is not returning the correct data.

Thank you

@rviscomi
Copy link
Member

Updated the query in #10 (comment) to return the expected format

@maceto maceto closed this as completed Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants