From 44e4d31e0f7d7945513c2d465035eb173e482f57 Mon Sep 17 00:00:00 2001
From: Ville Pihlava <ville.pihlava@cgi.com>
Date: Fri, 29 Nov 2024 15:13:55 +0200
Subject: [PATCH] Add test for mode-specific transfers.

---
 .../module/DirectTransferGeneratorTest.java   | 59 ++++++++++++++++++-
 1 file changed, 57 insertions(+), 2 deletions(-)

diff --git a/application/src/test/java/org/opentripplanner/graph_builder/module/DirectTransferGeneratorTest.java b/application/src/test/java/org/opentripplanner/graph_builder/module/DirectTransferGeneratorTest.java
index 8a17e5258d8..310e474ae99 100644
--- a/application/src/test/java/org/opentripplanner/graph_builder/module/DirectTransferGeneratorTest.java
+++ b/application/src/test/java/org/opentripplanner/graph_builder/module/DirectTransferGeneratorTest.java
@@ -196,7 +196,7 @@ public void testMultipleRequestsWithoutPatterns() {
     reqWalk.journey().transfer().setMode(StreetMode.WALK);
 
     var reqBike = new RouteRequest();
-    reqWalk.journey().transfer().setMode(StreetMode.BIKE);
+    reqBike.journey().transfer().setMode(StreetMode.BIKE);
 
     var transferRequests = List.of(reqWalk, reqBike);
 
@@ -223,7 +223,7 @@ public void testMultipleRequestsWithPatterns() {
     reqWalk.journey().transfer().setMode(StreetMode.WALK);
 
     var reqBike = new RouteRequest();
-    reqWalk.journey().transfer().setMode(StreetMode.BIKE);
+    reqBike.journey().transfer().setMode(StreetMode.BIKE);
 
     var transferRequests = List.of(reqWalk, reqBike);
 
@@ -250,6 +250,61 @@ public void testMultipleRequestsWithPatterns() {
     );
   }
 
+  @Test
+  public void testPathTransfersWithModesForMultipleRequestsWithPatterns() {
+    var reqWalk = new RouteRequest();
+    reqWalk.journey().transfer().setMode(StreetMode.WALK);
+
+    var reqBike = new RouteRequest();
+    reqBike.journey().transfer().setMode(StreetMode.BIKE);
+
+    var transferRequests = List.of(reqWalk, reqBike);
+
+    TestOtpModel model = model(true);
+    var graph = model.graph();
+    graph.hasStreets = true;
+    var timetableRepository = model.timetableRepository();
+
+    new DirectTransferGenerator(
+      graph,
+      timetableRepository,
+      DataImportIssueStore.NOOP,
+      MAX_TRANSFER_DURATION,
+      transferRequests
+    )
+      .buildGraph();
+
+    var walkTransfers = timetableRepository
+      .getAllPathTransfers()
+      .stream()
+      .filter(pathTransfer -> pathTransfer.getModes().contains(StreetMode.WALK))
+      .toList();
+    var bikeTransfers = timetableRepository
+      .getAllPathTransfers()
+      .stream()
+      .filter(pathTransfer -> pathTransfer.getModes().contains(StreetMode.BIKE))
+      .toList();
+    var carTransfers = timetableRepository
+      .getAllPathTransfers()
+      .stream()
+      .filter(pathTransfer -> pathTransfer.getModes().contains(StreetMode.CAR))
+      .toList();
+
+    assertTransfers(
+      walkTransfers,
+      tr(S0, 100, List.of(V0, V11), S11),
+      tr(S0, 100, List.of(V0, V21), S21),
+      tr(S11, 100, List.of(V11, V21), S21)
+    );
+    assertTransfers(
+      bikeTransfers,
+      tr(S0, 100, List.of(V0, V11), S11),
+      tr(S0, 100, List.of(V0, V21), S21),
+      tr(S11, 110, List.of(V11, V22), S22)
+    );
+    assertTransfers(carTransfers);
+  }
+
   @Test
   public void testTransferOnIsolatedStations() {
     var otpModel = model(true, false, true);