Skip to content

UMAP feature_weights refactoring #2

@alessiamarcolini

Description

@alessiamarcolini

_get_feat_weights method of an UmapExperiment (https://github.com/HK3-Lab-Team/umapviz/blob/master/src/umapviz/umap_exp.py#L460) is called to get the feature weights, and in case self.feature_weights = () they are calculated and then the result is set to the feature_weights attribute and it is returned, too. Is that right?

If so, why not having a feature_weights property who calculates the result? If performance is a concern, we can cache the result so subsequent calls to the property won't trigger the calculation.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions