Skip to content

Commit 9b07ee4

Browse files
committed
chore: Update node to 24 and remove bun as assets are not yet good enough suported by the bun compile command to be able to use it
1 parent 2a95124 commit 9b07ee4

19 files changed

+78
-2687
lines changed

.github/workflows/bun-binary.yml

Lines changed: 0 additions & 77 deletions
This file was deleted.

.github/workflows/deploy-npm.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ on:
44
workflow_call:
55
inputs:
66
node-version:
7-
default: "20"
7+
default: "24"
88
description: The node version to use
99
required: false
1010
type: string

.github/workflows/dev-release.yml

Lines changed: 40 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -25,42 +25,42 @@ jobs:
2525
arch: ${{ matrix.arch }}
2626
edge: true
2727
filename: lando-${{ matrix.os }}-${{ matrix.arch }}-${{ github.sha }}
28-
node-version: "20"
28+
node-version: "24"
2929
os: ${{ matrix.os }}
3030
version: dev
3131

32-
sign:
33-
uses: ./.github/workflows/sign-binary.yml
34-
needs:
35-
- package
36-
strategy:
37-
fail-fast: false
38-
matrix:
39-
file:
40-
- lando-linux-arm64-${{ github.sha }}
41-
- lando-macos-arm64-${{ github.sha }}
42-
- lando-win-arm64-${{ github.sha }}
32+
#sign:
33+
# uses: ./.github/workflows/sign-binary.yml
34+
# needs:
35+
# - package
36+
# strategy:
37+
# fail-fast: false
38+
# matrix:
39+
# file:
40+
# - lando-linux-arm64-${{ github.sha }}
41+
# - lando-macos-arm64-${{ github.sha }}
42+
# - lando-win-arm64-${{ github.sha }}
4343

44-
- lando-linux-x64-${{ github.sha }}
45-
- lando-macos-x64-${{ github.sha }}
46-
- lando-win-x64-${{ github.sha }}
44+
# - lando-linux-x64-${{ github.sha }}
45+
# - lando-macos-x64-${{ github.sha }}
46+
# - lando-win-x64-${{ github.sha }}
4747

48-
with:
49-
download-pattern: packaged-lando-*
50-
file: ${{ matrix.file }}
51-
secrets:
52-
apple-notary-user: ${{ secrets.APPLE_NOTARY_USER }}
53-
apple-notary-password: ${{ secrets.APPLE_NOTARY_PASSWORD }}
54-
certificate-data: ${{ contains(matrix.file, 'macos') && secrets.APPLE_CERT_DATA || secrets.KEYLOCKER_CLIENT_CERT }}
55-
certificate-password: ${{ contains(matrix.file, 'macos') && secrets.APPLE_CERT_PASSWORD || secrets.KEYLOCKER_CLIENT_CERT_PASSWORD }}
56-
keylocker-api-key: ${{ secrets.KEYLOCKER_API_KEY }}
57-
keylocker-cert-sha1-hash: ${{ secrets.KEYLOCKER_CERT_SHA1_HASH }}
58-
keylocker-keypair-alias: ${{ secrets.KEYLOCKER_KEYPAIR_ALIAS }}
48+
# with:
49+
# download-pattern: packaged-lando-*
50+
# file: ${{ matrix.file }}
51+
# secrets:
52+
# apple-notary-user: ${{ secrets.APPLE_NOTARY_USER }}
53+
# apple-notary-password: ${{ secrets.APPLE_NOTARY_PASSWORD }}
54+
# certificate-data: ${{ contains(matrix.file, 'macos') && secrets.APPLE_CERT_DATA || secrets.KEYLOCKER_CLIENT_CERT }}
55+
# certificate-password: ${{ contains(matrix.file, 'macos') && secrets.APPLE_CERT_PASSWORD || secrets.KEYLOCKER_CLIENT_CERT_PASSWORD }}
56+
# keylocker-api-key: ${{ secrets.KEYLOCKER_API_KEY }}
57+
# keylocker-cert-sha1-hash: ${{ secrets.KEYLOCKER_CERT_SHA1_HASH }}
58+
# keylocker-keypair-alias: ${{ secrets.KEYLOCKER_KEYPAIR_ALIAS }}
5959

6060
build-release-binary-alias:
6161
uses: ./.github/workflows/release-rename-binary.yml
6262
needs:
63-
- sign
63+
- package
6464
strategy:
6565
fail-fast: false
6666
matrix:
@@ -77,11 +77,11 @@ jobs:
7777
with:
7878
source: lando-${{ matrix.os }}-${{ matrix.arch }}-${{ github.sha }}
7979
destination: lando-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.alias }}
80-
download-pattern: signed-lando-*
80+
download-pattern: packaged-lando-*
8181
build-release-binary-branch:
8282
uses: ./.github/workflows/release-rename-binary.yml
8383
needs:
84-
- sign
84+
- package
8585
strategy:
8686
fail-fast: false
8787
matrix:
@@ -96,7 +96,7 @@ jobs:
9696
with:
9797
source: lando-${{ matrix.os }}-${{ matrix.arch }}-${{ github.sha }}
9898
destination: lando-${{ matrix.os }}-${{ matrix.arch }}-${{ github.head_ref || github.ref_name }}
99-
download-pattern: signed-lando-*
99+
download-pattern: packaged-lando-*
100100

101101
checksum:
102102
uses: ./.github/workflows/generate-checksums.yml
@@ -116,16 +116,16 @@ jobs:
116116
show: true
117117
upload-name: release-checksums-${{ matrix.alias }}
118118

119-
deploy-releases-s3:
120-
uses: ./.github/workflows/deploy-s3.yml
121-
needs:
122-
- checksum
123-
with:
124-
download-pattern: release-*
125-
secrets:
126-
aws-secret-access-key: ${{ secrets.S3_SECRET_ACCESS_KEY }}
127-
aws-access-key-id: ${{ secrets.S3_ACCESS_KEY_ID }}
128-
aws-region: us-east-1
119+
#deploy-releases-s3:
120+
# uses: ./.github/workflows/deploy-s3.yml
121+
# needs:
122+
# - checksum
123+
# with:
124+
# download-pattern: release-*
125+
# secrets:
126+
# aws-secret-access-key: ${{ secrets.S3_SECRET_ACCESS_KEY }}
127+
# aws-access-key-id: ${{ secrets.S3_ACCESS_KEY_ID }}
128+
# aws-region: us-east-1
129129
deploy-releases-artifacts:
130130
uses: ./.github/workflows/deploy-artifacts.yml
131131
needs:

.github/workflows/pkg-binary.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ on:
1919
required: false
2020
type: string
2121
node-version:
22-
default: "20"
22+
default: "24"
2323
description: The node version to build for eg 16 | 18 | 20
2424
required: true
2525
type: string
@@ -71,7 +71,7 @@ jobs:
7171
node-version: ${{ inputs.node-version }}
7272
os: ${{ inputs.os }}
7373
options: --options dns-result-order=ipv4first
74-
pkg: "@yao-pkg/pkg@5.16.1"
74+
pkg: "@yao-pkg/pkg@6.10.1"
7575
upload-key: "packaged-${{ inputs.filename }}-${{ inputs.os }}-${{ inputs.arch }}-${{ github.sha }}"
7676
- name: Ensure version
7777
if: (inputs.os == 'linux' && runner.os == 'Linux') || (inputs.os == 'macos' && runner.os == 'macOS')
@@ -82,8 +82,8 @@ jobs:
8282
- name: Ensure channel
8383
if: (inputs.os == 'linux' && runner.os == 'Linux') || (inputs.os == 'macos' && runner.os == 'macOS')
8484
run: ./dist/${{ inputs.filename }} config --path channel | grep ${{ inputs.edge == true && 'edge' || 'stable' }}
85-
- name: Ensure plugin install
86-
if: ((inputs.os == 'linux' && runner.os == 'Linux') || (inputs.os == 'macos' && runner.os == 'macOS'))
87-
run: |
88-
./dist/${{ inputs.filename }} config --path fatcore | grep false
89-
#./dist/${{ inputs.filename }} config | grep -q "/snapshot/core/plugins/wordpress"
85+
#- name: Ensure plugin install
86+
# if: ((inputs.os == 'linux' && runner.os == 'Linux') || (inputs.os == 'macos' && runner.os == 'macOS'))
87+
# run: |
88+
# ./dist/${{ inputs.filename }} config --path fatcore | grep false
89+
# #./dist/${{ inputs.filename }} config | grep -q "/snapshot/core/plugins/wordpress"

.github/workflows/pr-core-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ jobs:
6363
- version
6464
- yaml
6565
node-version:
66-
- "20"
66+
- "24"
6767
os:
6868
# - macos-14
6969
- ubuntu-24.04

.github/workflows/pr-docs-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
os:
1414
- ubuntu-24.04
1515
node-version:
16-
- "20"
16+
- "24"
1717
steps:
1818
- name: Checkout code
1919
uses: actions/checkout@v4
@@ -48,7 +48,7 @@ jobs:
4848
os:
4949
- ubuntu-24.04
5050
node-version:
51-
- "20"
51+
- "24"
5252
steps:
5353
- name: Checkout code
5454
uses: actions/checkout@v4

.github/workflows/pr-license-check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
os:
1212
- ubuntu-24.04
1313
node-version:
14-
- "20"
14+
- "24"
1515
steps:
1616
- name: Checkout code
1717
uses: actions/checkout@v4

.github/workflows/pr-linter.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
os:
1212
- ubuntu-24.04
1313
node-version:
14-
- "20"
14+
- "24"
1515
steps:
1616
# Install deps and cache
1717
- name: Checkout code

.github/workflows/pr-release-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
with:
2020
arch: ${{ matrix.arch }}
2121
filename: lando-${{ matrix.os }}-${{ matrix.arch }}-${{ github.sha }}
22-
node-version: "20"
22+
node-version: "24"
2323
os: ${{ matrix.os }}
2424
version: dev
2525

@@ -61,7 +61,7 @@ jobs:
6161
strategy:
6262
matrix:
6363
node-version:
64-
- '20'
64+
- '24'
6565
steps:
6666
- name: Checkout code
6767
uses: actions/checkout@v4

.github/workflows/pr-setup-linux-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
leia-test:
1515
- setup-linux
1616
node-version:
17-
- "20"
17+
- "24"
1818
os:
1919
- ubuntu-24.04
2020

0 commit comments

Comments
 (0)