fix: Lint errors

Author: florianPat

builders/_lando-compose.js

@@ -3,9 +3,9 @@
 module.exports = {
   name: '_lando-compose',
   parent: '_lando',
-  builder: (parent, config) => class LandoComposeServiceV3 extends parent {
+  builder: parent => class LandoComposeServiceV3 extends parent {
     constructor(id, options = {}) {
       super(id, options);
-    };
+    }
   },
 };

utils/parse-events-config.js

@@ -40,9 +40,23 @@ module.exports = (cmds, app, data, lando) => _.map(cmds, cmd => {
   // Discover the service
   const service = getService(cmd, data, app._defaultService);
 
+  // compute stdio based on compose major version
+  const cstdio = _.get(app, '_config.orchestratorMV', 2) ? 'inherit' : ['inherit', 'pipe', 'pipe'];
+
+  // attempt to ascertain the SAPI
+  const sapi = _.get(app, 'v4.services', []).find(s => s.id === service)?.api
+    ?? _.get(app, `sapis.${service}`, undefined)
+    ?? _.get(data, `sapis.${service}`, undefined);
+
+  // normalize cmd
+  cmd = getCommand(cmd);
+
+  // if array then just join it together
+  if (_.isArray(cmd)) cmd = cmd.join(' ');
+
   if ('lando' === service) {
     const yargs = require('yargs');
-    const argv = yargs(_.isArray(command) ? command.join(' ') : command).parse();
+    const argv = yargs(cmd).parse();
     const $0 = _.pullAt(argv._, [0])[0];
     const toolingTask = _.find(app.tasks, task => $0 === task.command);
     argv._eventArgs = argv._;
@@ -59,20 +73,6 @@ module.exports = (cmds, app, data, lando) => _.map(cmds, cmd => {
     };
   }
 
-  // compute stdio based on compose major version
-  const cstdio = _.get(app, '_config.orchestratorMV', 2) ? 'inherit' : ['inherit', 'pipe', 'pipe'];
-
-  // attempt to ascertain the SAPI
-  const sapi = _.get(app, 'v4.services', []).find(s => s.id === service)?.api
-    ?? _.get(app, `sapis.${service}`, undefined)
-    ?? _.get(data, `sapis.${service}`, undefined);
-
-  // normalize cmd
-  cmd = getCommand(cmd);
-
-  // if array then just join it together
-  if (_.isArray(cmd)) cmd = cmd.join(' ');
-
   // lando 4 services
   // @NOTE: lando 4 service events will change once we have a complete hook system
   if (sapi === 4) {

utils/parse-tooling-config.js

@@ -20,7 +20,7 @@ const getDynamicKeys = (answer, answers = {}) => _(answers)
  * Set SERVICE from answers and strip out that noise from the rest of
  * stuff, check answers/argv for --service or -s, validate and then remove
  */
-const handleDynamic = (config, argv, options = {}, answers = {}, sapis = {}) => {
+const handleDynamic = (config, argv, answers = {}, sapis = {}) => {
   if (_.startsWith(config.service, ':')) {
     const answer = answers[config.service.split(':')[1]];
     // Remove dynamic service option from argv
@@ -78,7 +78,7 @@ module.exports = (cmd, service, name, options = {}, answers = {}, sapis = {}) =>
   // Put into an object so we can handle "multi-service" tooling
   .map(cmd => parseCommand(cmd, service, sapis))
   // Handle dynamic services
-  .map(config => handleDynamic(config, answers._eventArgs ?? process.argv, options, answers, sapis))
+  .map(config => handleDynamic(config, answers._eventArgs ?? process.argv, answers, sapis))
   // Add in any argv extras if they've been passed in
   .map(config => handleOpts(config, name, answers._eventArgs ?? process.argv, handlePassthruOpts(options, answers)))
   // Wrap the command in /bin/sh if that makes sense