-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename to 'WindowActivityTracker' #4
Comments
Good point, we should probably do that (@casaout thoughts?). We need to be a bit careful since lots of repos use this as a git submodule. Would probably make sense to work out a "migration guide" for these affected repos. |
I agree that the part The tracker is actually doing several things:
So maybe, we can think of an entirely better name? (e.g. AppActivityTracker) Also, changing the name might require a couple of refactorings, if we're doing this properly - it's used in several student projects, some of ours, and (the C# and Swift versions) in the public PersonalAnalytics repo. |
Would just Another option is should we even keep the suffix "Tracker?" Would |
It depends quite a bit on how it's actually used in the end. Many projects never use the activity categories, but just the "raw" data which is the start + end time and window title of a process that was in the foreground. I agree, the Note that the WindowsActivityTracker does not just perform the mapping, but also collect the actual raw data through OS hooks. |
This tracker tracks window activity, and to avoid misunderstandings with the operating system "Windows" it might be worth renaming it. This clarifies that the tracker also works on non-windows systems.
The text was updated successfully, but these errors were encountered: