From adf933485e2e7301f215c30fed357601dfa5dbf8 Mon Sep 17 00:00:00 2001
From: Matteo Scurati <matteo.scurati@gmail.com>
Date: Sat, 18 Dec 2021 09:26:51 +0100
Subject: [PATCH] Fix HAL plugin proposal

---
 src/components/Plugin/Hal/CustomBlock.vue | 38 +++++++----------------
 1 file changed, 12 insertions(+), 26 deletions(-)

diff --git a/src/components/Plugin/Hal/CustomBlock.vue b/src/components/Plugin/Hal/CustomBlock.vue
index c611b0f4cc95..a947958882cd 100644
--- a/src/components/Plugin/Hal/CustomBlock.vue
+++ b/src/components/Plugin/Hal/CustomBlock.vue
@@ -1,36 +1,22 @@
 <script setup>
+import { computed } from 'vue';
 const props = defineProps({
   space: Object
 });
-
-const getSpaceId = () => {
-  const spaceId = props.space.id;
-  return spaceId;
-};
-
-const getSpaceName = () => {
-  const spaceName = props.space.name;
-  return spaceName;
-};
-
-const getHalUrl = () => {
-  const spaceId = getSpaceId();
-  return `https://9000.staging.hal.xyz/recipes/snapshot-follow-new-proposals?space-id=${spaceId}&status=end`;
-};
-
-const getLogoUrl = () => {
-  return `https://hal-snapshot-plugin.s3.eu-west-1.amazonaws.com/hal_bell.svg`;
-};
+const halUrl = computed(
+  () =>
+    `https://9000.hal.xyz/recipes/snapshot-follow-new-proposals?space-id=${props.space.id}&status=end`
+);
+const halLogoUrl = computed(
+  () => 'https://hal-snapshot-plugin.s3.eu-west-1.amazonaws.com/hal_bell.svg'
+);
 </script>
 
 <template>
-  <Block
-    :title="$t('hal.title', { spaceName: getSpaceName() })"
-    :loading="loading"
-  >
+  <Block :title="$t('hal.title', { spaceName: space.name })" :loading="loading">
     <div class="flex flex-col items-center">
       <div>
-        <a :href="getHalUrl()" target="_blank">
+        <a :href="halUrl" target="_blank">
           <img
             class="
               rounded-full
@@ -39,7 +25,7 @@ const getLogoUrl = () => {
               mx-auto
               mb-2
             "
-            :src="getLogoUrl()"
+            :src="halLogoUrl"
             alt="Hal"
             width="100"
             height="100"
@@ -47,7 +33,7 @@ const getLogoUrl = () => {
         </a>
       </div>
       <div class="link-color text-center mb-2">{{ $t('hal.text') }}</div>
-      <a :href="getHalUrl()" target="_blank">
+      <a :href="halUrl" target="_blank">
         <UiButton>Be notified</UiButton>
       </a>
     </div>