Skip to content

docs(api): fix the Sphinx warnings of module docstrings and PyQt signals - #533

Merged
Guts merged 2 commits into
masterfrom
docs/fix-docstrings-sphinx-warnings
Nov 6, 2026
Merged

Guts merged 2 commits into
masterfrom
docs/fix-docstrings-sphinx-warnings

Conversation

@Guts

@Guts Guts commented Nov 6, 2026

Copy link
Copy Markdown
Owner

Description

Remove the Sphinx warnings that appeared on the API pages of dicogis.ui now that PyQt6 is installed in the documentation build (#532):

  • six module docstrings raised "Unexpected indentation": the Name/Purpose/Author headers of wdg_tab_publish, workers, progress and read_vector_flat_dataset become a reStructuredText field list, and the continuation lines of ui/main and mw_dicogis are dedented;
  • the unescaped *.dbconf of read_db_conf is put in a literal;
  • PyQt gives every signal without a docstring of its own a generic one containing *types, read as an unfinished emphasis: a small autodoc-process-docstring hook in docs/conf.py drops it and leaves the signals documented by hand untouched.

The six docstrings were checked with docutils and the hook on a minimal Sphinx project; the full build has not been run locally (it needs GDAL), so the CI run of this PR is the confirmation.

Related issue(s)

Follows #532.

Type of change

  • Bug fix (fix/… branch)
  • New feature or enhancement (feature/… branch)
  • Documentation (docs/… branch or *.md/docs/** changes)
  • Packaging / build (packaging/… branch or builder/** changes)
  • Tooling / CI-CD (tooling/… branch or .github/** changes)
  • Tests only (tests/** changes)

Checklist

  • I have read the Contributing Guidelines
  • pre-commit run --all-files passes locally
  • I have added or updated tests covering my changes
  • I have updated the documentation where relevant
  • pytest passes locally

AI/LLM disclosure


Generated by Claude Code

Sphinx reported "Unexpected indentation" on six module docstrings whose continuation lines were indented, and an unfinished emphasis on the unescaped *.dbconf of read_db_conf. Use a reStructuredText field list for the Name/Purpose/Author headers, dedent the others and put the glob in a literal.

AI-Level: 7
AI-Model: Claude Sonnet 5.5
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CUNZAXTg3vthj5KZYCgf3m
Autodoc documents every pyqtSignal with PyQt's own docstring, whose "*types" docutils reads as an unfinished emphasis, producing a warning per signal. Remove it from the processed docstring, leaving the signals documented by a docstring of their own untouched.

AI-Level: 7
AI-Model: Claude Sonnet 5.5
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CUNZAXTg3vthj5KZYCgf3m
@github-actions github-actions Bot added bug Houston, we've a problem! documentation Improvements or additions to documentation labels Nov 6, 2026
@sonarqubecloud

sonarqubecloud Bot commented Nov 6, 2026

Copy link
Copy Markdown

@Guts
Guts enabled auto-merge November 6, 2026 19:53
@codecov

codecov Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.23%. Comparing base (12e28d1) to head (ce29ed6).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #533   +/-   ##
=======================================
  Coverage   78.23%   78.23%           
=======================================
  Files          54       54           
  Lines        3469     3469           
  Branches      435      435           
=======================================
  Hits         2714     2714           
  Misses        633      633           
  Partials      122      122           
Flag Coverage Δ
unittests 78.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dicogis/georeaders/read_vector_flat_dataset.py 66.23% <ø> (ø)
dicogis/ui/main.py 44.68% <ø> (ø)
dicogis/ui/mw_dicogis.py 61.18% <ø> (ø)
dicogis/ui/wdg_tab_publish.py 79.72% <ø> (ø)
dicogis/ui/workers.py 67.46% <ø> (ø)
dicogis/utils/db_conf_reader.py 66.66% <ø> (ø)
dicogis/utils/progress.py 73.33% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Guts
Guts merged commit a6c6937 into master Nov 6, 2026
16 of 17 checks passed
@Guts
Guts deleted the docs/fix-docstrings-sphinx-warnings branch November 6, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Houston, we've a problem! documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants