Skip to content

Handling editing of lyrics after syncing #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gigareggie opened this issue Jan 11, 2025 · 1 comment · May be fixed by #10
Open

Handling editing of lyrics after syncing #9

gigareggie opened this issue Jan 11, 2025 · 1 comment · May be fixed by #10
Assignees
@sortedcord
Labels
bug Something isn't working enhancement New feature or request

Comments

@gigareggie
Copy link
Collaborator

I was thinking about editing of lyrics will go about once the user has already synced a few elements and then decides to edit the lyrics and goes back to the editing tab? Could be any of the following

  • Timestamps reset (Lazy fix - probably the easiest)
  • Modified line reset (check for which lines have been modified and then reset those lines' timestamps.)
  • VocalElement check (slowest and probably the hardest to implement - check what all elements have been modified, then map those)
@gigareggie gigareggie added bug Something isn't working enhancement New feature or request labels Jan 11, 2025
@sortedcord
Copy link
Collaborator

I believe it would be better to prevent users from changing lyrics from the edit tab once they start syncing the lyrics. We can have options in the sync tab itself to let people change individual elements like changing the text, splitting VocalElements, deleting and adding new elements. If the user still wants to go back to the edit tab, then they can do so and make the changes, however the lines they change will be reset (i.e the second option you specified)

@sortedcord sortedcord self-assigned this Jan 12, 2025
@sortedcord sortedcord linked a pull request Jan 12, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sortedcord sortedcord

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editing capabilities after import Groovbox/pyAMLL
2 participants
@sortedcord @gigareggie