switched from HashSet to ArrayList.

PrototypeTrousers · PrototypeTrousers · commit fb9ae22416b6 · 2021-04-02T11:46:18.000-03:00
diff --git a/src/main/java/gregtech/api/capability/INotifiableHandler.java b/src/main/java/gregtech/api/capability/INotifiableHandler.java
@@ -2,8 +2,8 @@
 
 import gregtech.api.metatileentity.MetaTileEntity;
 
-import java.util.HashSet;
 import java.util.Iterator;
+import java.util.List;
 
 /**
  * For Item and Fluid handlers capable of notifying entities when
@@ -20,21 +20,21 @@ public interface INotifiableHandler {
     default void notifyMetaTileEntitiesOfChange(boolean isExport) {
         Iterator<MetaTileEntity> iterator = getNotifiableMetaTileEntities().iterator();
         while (iterator.hasNext()) {
-            MetaTileEntity mte = iterator.next();
-            if (mte != null && mte.isValid()) {
-                if (isExport) mte.setOutputsDirty(true);
-                else mte.setInputsDirty(true);
+            MetaTileEntity metaTileEntity = iterator.next();
+            if (metaTileEntity != null && metaTileEntity.isValid()) {
+                if (isExport) metaTileEntity.setOutputsDirty(true);
+                else metaTileEntity.setInputsDirty(true);
             } else {
                 iterator.remove();
             }
         }
     }
 
     /**
-     * returns a HashSet containing the notifiable MetaTileEntities
+     * returns a List containing the notifiable MetaTileEntities
      * @return
      */
-    HashSet<MetaTileEntity> getNotifiableMetaTileEntities();
+    List<MetaTileEntity> getNotifiableMetaTileEntities();
 
     /**
      *
diff --git a/src/main/java/gregtech/api/capability/impl/NotifiableFilteredFluidHandler.java b/src/main/java/gregtech/api/capability/impl/NotifiableFilteredFluidHandler.java
@@ -3,11 +3,12 @@
 import gregtech.api.capability.INotifiableHandler;
 import gregtech.api.metatileentity.MetaTileEntity;
 
-import java.util.HashSet;
+import java.util.ArrayList;
+import java.util.List;
 
 public class NotifiableFilteredFluidHandler extends FilteredFluidHandler implements INotifiableHandler {
 
-    HashSet<MetaTileEntity> entitiesToNotify = new HashSet<>();
+    List<MetaTileEntity> entitiesToNotify = new ArrayList<>();
     private final boolean isExport;
 
     public NotifiableFilteredFluidHandler(int capacity, MetaTileEntity entityToNotify, boolean isExport) {
@@ -23,7 +24,7 @@ protected void onContentsChanged() {
     }
 
     @Override
-    public HashSet<MetaTileEntity> getNotifiableMetaTileEntities() {
+    public List<MetaTileEntity> getNotifiableMetaTileEntities() {
         return this.entitiesToNotify;
     }
 }
diff --git a/src/main/java/gregtech/api/capability/impl/NotifiableFluidTank.java b/src/main/java/gregtech/api/capability/impl/NotifiableFluidTank.java
@@ -4,11 +4,12 @@
 import gregtech.api.metatileentity.MetaTileEntity;
 import net.minecraftforge.fluids.FluidTank;
 
-import java.util.HashSet;
+import java.util.ArrayList;
+import java.util.List;
 
 public class NotifiableFluidTank extends FluidTank implements INotifiableHandler {
 
-    HashSet<MetaTileEntity> entitiesToNotify = new HashSet<>();
+    List<MetaTileEntity> entitiesToNotify = new ArrayList<>();
     private final boolean isExport;
 
     public NotifiableFluidTank(int capacity, MetaTileEntity entityToNotify, boolean isExport) {
@@ -24,7 +25,7 @@ protected void onContentsChanged() {
     }
 
     @Override
-    public HashSet<MetaTileEntity> getNotifiableMetaTileEntities() {
+    public List<MetaTileEntity> getNotifiableMetaTileEntities() {
         return this.entitiesToNotify;
     }
 }
diff --git a/src/main/java/gregtech/api/capability/impl/NotifiableItemStackHandler.java b/src/main/java/gregtech/api/capability/impl/NotifiableItemStackHandler.java
@@ -5,11 +5,12 @@
 import net.minecraftforge.items.IItemHandlerModifiable;
 import net.minecraftforge.items.ItemStackHandler;
 
-import java.util.HashSet;
+import java.util.ArrayList;
+import java.util.List;
 
 public class NotifiableItemStackHandler extends ItemStackHandler implements IItemHandlerModifiable, INotifiableHandler {
 
-    HashSet<MetaTileEntity> entitiesToNotify = new HashSet<>();
+    List<MetaTileEntity> entitiesToNotify = new ArrayList<>();
     private final boolean isExport;
 
     public NotifiableItemStackHandler(int slots, MetaTileEntity entityToNotify, boolean isExport) {
@@ -25,7 +26,7 @@ public void onContentsChanged(int slot) {
     }
 
     @Override
-    public HashSet<MetaTileEntity> getNotifiableMetaTileEntities() {
+    public List<MetaTileEntity> getNotifiableMetaTileEntities() {
         return this.entitiesToNotify;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -3,11 +3,12 @@`
`3`	`3`	`import gregtech.api.capability.INotifiableHandler;`
`4`	`4`	`import gregtech.api.metatileentity.MetaTileEntity;`
`5`	`5`
`6`		`-import java.util.HashSet;`
	`6`	`+import java.util.ArrayList;`
	`7`	`+import java.util.List;`
`7`	`8`
`8`	`9`	`public class NotifiableFilteredFluidHandler extends FilteredFluidHandler implements INotifiableHandler {`
`9`	`10`
`10`		`- HashSet<MetaTileEntity> entitiesToNotify = new HashSet<>();`
	`11`	`+ List<MetaTileEntity> entitiesToNotify = new ArrayList<>();`
`11`	`12`	`private final boolean isExport;`
`12`	`13`
`13`	`14`	`public NotifiableFilteredFluidHandler(int capacity, MetaTileEntity entityToNotify, boolean isExport) {`
`@@ -23,7 +24,7 @@ protected void onContentsChanged() {`
`23`	`24`	`}`
`24`	`25`
`25`	`26`	`@Override`
`26`		`- public HashSet<MetaTileEntity> getNotifiableMetaTileEntities() {`
	`27`	`+ public List<MetaTileEntity> getNotifiableMetaTileEntities() {`
`27`	`28`	`return this.entitiesToNotify;`
`28`	`29`	`}`
`29`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,11 +4,12 @@`
`4`	`4`	`import gregtech.api.metatileentity.MetaTileEntity;`
`5`	`5`	`import net.minecraftforge.fluids.FluidTank;`
`6`	`6`
`7`		`-import java.util.HashSet;`
	`7`	`+import java.util.ArrayList;`
	`8`	`+import java.util.List;`
`8`	`9`
`9`	`10`	`public class NotifiableFluidTank extends FluidTank implements INotifiableHandler {`
`10`	`11`
`11`		`- HashSet<MetaTileEntity> entitiesToNotify = new HashSet<>();`
	`12`	`+ List<MetaTileEntity> entitiesToNotify = new ArrayList<>();`
`12`	`13`	`private final boolean isExport;`
`13`	`14`
`14`	`15`	`public NotifiableFluidTank(int capacity, MetaTileEntity entityToNotify, boolean isExport) {`
`@@ -24,7 +25,7 @@ protected void onContentsChanged() {`
`24`	`25`	`}`
`25`	`26`
`26`	`27`	`@Override`
`27`		`- public HashSet<MetaTileEntity> getNotifiableMetaTileEntities() {`
	`28`	`+ public List<MetaTileEntity> getNotifiableMetaTileEntities() {`
`28`	`29`	`return this.entitiesToNotify;`
`29`	`30`	`}`
`30`	`31`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,11 +5,12 @@`
`5`	`5`	`import net.minecraftforge.items.IItemHandlerModifiable;`
`6`	`6`	`import net.minecraftforge.items.ItemStackHandler;`
`7`	`7`
`8`		`-import java.util.HashSet;`
	`8`	`+import java.util.ArrayList;`
	`9`	`+import java.util.List;`
`9`	`10`
`10`	`11`	`public class NotifiableItemStackHandler extends ItemStackHandler implements IItemHandlerModifiable, INotifiableHandler {`
`11`	`12`
`12`		`- HashSet<MetaTileEntity> entitiesToNotify = new HashSet<>();`
	`13`	`+ List<MetaTileEntity> entitiesToNotify = new ArrayList<>();`
`13`	`14`	`private final boolean isExport;`
`14`	`15`
`15`	`16`	`public NotifiableItemStackHandler(int slots, MetaTileEntity entityToNotify, boolean isExport) {`
`@@ -25,7 +26,7 @@ public void onContentsChanged(int slot) {`
`25`	`26`	`}`
`26`	`27`
`27`	`28`	`@Override`
`28`		`- public HashSet<MetaTileEntity> getNotifiableMetaTileEntities() {`
	`29`	`+ public List<MetaTileEntity> getNotifiableMetaTileEntities() {`
`29`	`30`	`return this.entitiesToNotify;`
`30`	`31`	`}`
`31`	`32`	`}`