Skip to content

Commit 40a4e1a

Browse files
committed
fix: add explanations to nolint:ireturn directives
1 parent e80f1a7 commit 40a4e1a

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

cmd/trace/cli/review/cmd.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -724,7 +724,7 @@ type perAgentConfiguredReviewer struct {
724724
}
725725

726726
func (r *perAgentConfiguredReviewer) Name() string { return r.inner.Name() }
727-
func (r *perAgentConfiguredReviewer) Start(ctx context.Context, _ reviewtypes.RunConfig) (reviewtypes.Process, error) { //nolint:ireturn
727+
func (r *perAgentConfiguredReviewer) Start(ctx context.Context, _ reviewtypes.RunConfig) (reviewtypes.Process, error) { //nolint:ireturn // interface required by contract
728728
return r.inner.Start(ctx, r.cfg) //nolint:wrapcheck // transparent adapter; callers see inner's error type directly
729729
}
730730

cmd/trace/cli/review/run_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ type stubReviewer struct {
1717
}
1818

1919
func (s *stubReviewer) Name() string { return s.name }
20-
func (s *stubReviewer) Start(_ context.Context, _ reviewtypes.RunConfig) (reviewtypes.Process, error) { //nolint:ireturn
20+
func (s *stubReviewer) Start(_ context.Context, _ reviewtypes.RunConfig) (reviewtypes.Process, error) { //nolint:ireturn // interface required by contract
2121
if s.startErr != nil {
2222
return nil, s.startErr
2323
}
@@ -159,7 +159,7 @@ type funcReviewer struct {
159159
}
160160

161161
func (r *funcReviewer) Name() string { return r.name }
162-
func (r *funcReviewer) Start(_ context.Context, _ reviewtypes.RunConfig) (reviewtypes.Process, error) { //nolint:ireturn
162+
func (r *funcReviewer) Start(_ context.Context, _ reviewtypes.RunConfig) (reviewtypes.Process, error) { //nolint:ireturn // interface required by contract
163163
return r.process, nil
164164
}
165165

cmd/trace/cli/review/tui_model.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ func (m reviewTUIModel) Init() tea.Cmd {
108108
}
109109

110110
// Update handles all incoming messages.
111-
func (m reviewTUIModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) { //nolint:ireturn
111+
func (m reviewTUIModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) { //nolint:ireturn // interface required by contract
112112
switch msg := msg.(type) {
113113
case agentEventMsg:
114114
return m.handleAgentEvent(msg)
@@ -166,7 +166,7 @@ func (m reviewTUIModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) { //nolint:iret
166166
}
167167

168168
// handleAgentEvent processes an agentEventMsg, updating the relevant row.
169-
func (m reviewTUIModel) handleAgentEvent(msg agentEventMsg) (tea.Model, tea.Cmd) { //nolint:ireturn
169+
func (m reviewTUIModel) handleAgentEvent(msg agentEventMsg) (tea.Model, tea.Cmd) { //nolint:ireturn // interface required by contract
170170
idx, ok := m.rowIdx[msg.agent]
171171
if !ok {
172172
return m, nil
@@ -229,7 +229,7 @@ func (m reviewTUIModel) handleAgentEvent(msg agentEventMsg) (tea.Model, tea.Cmd)
229229
}
230230

231231
// handleKey processes keyboard input.
232-
func (m reviewTUIModel) handleKey(msg tea.KeyPressMsg) (tea.Model, tea.Cmd) { //nolint:ireturn
232+
func (m reviewTUIModel) handleKey(msg tea.KeyPressMsg) (tea.Model, tea.Cmd) { //nolint:ireturn // interface required by contract
233233
// Any key after finished dismisses.
234234
if m.finished {
235235
return m, tea.Quit

0 commit comments

Comments
 (0)