Skip to content

Commit 0fbe668

Browse files
committed
feat: add severity levels and update review concerns
1 parent 1131ddb commit 0fbe668

2 files changed

Lines changed: 18 additions & 41 deletions

File tree

internal/review/concerns.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,17 @@
11
// Package review implements the multi-concern LLM review pipeline.
22
package review
33

4+
import "github.com/GrayCodeAI/hawk/shared/types"
5+
46
// Severity mirrors the public type for internal use.
5-
type Severity int
7+
type Severity = types.Severity
68

79
const (
8-
SeverityInfo Severity = iota
9-
SeverityLow
10-
SeverityMedium
11-
SeverityHigh
12-
SeverityCritical
10+
SeverityInfo Severity = types.SeverityInfo
11+
SeverityLow Severity = types.SeverityLow
12+
SeverityMedium Severity = types.SeverityMedium
13+
SeverityHigh Severity = types.SeverityHigh
14+
SeverityCritical Severity = types.SeverityCritical
1315
)
1416

1517
// Concern defines a review focus area with its specialized prompt.

severity.go

Lines changed: 10 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,44 +1,19 @@
11
package sight
22

3-
import "strings"
3+
import "github.com/GrayCodeAI/hawk/shared/types"
44

55
// Severity represents the impact level of a review finding.
6-
type Severity int
6+
// Aliased from shared types for cross-module compatibility.
7+
type Severity = types.Severity
78

9+
// Severity constants re-exported for convenience.
810
const (
9-
SeverityInfo Severity = iota
10-
SeverityLow
11-
SeverityMedium
12-
SeverityHigh
13-
SeverityCritical
11+
SeverityInfo Severity = types.SeverityInfo
12+
SeverityLow Severity = types.SeverityLow
13+
SeverityMedium Severity = types.SeverityMedium
14+
SeverityHigh Severity = types.SeverityHigh
15+
SeverityCritical Severity = types.SeverityCritical
1416
)
1517

16-
var severityNames = [...]string{"info", "low", "medium", "high", "critical"}
17-
18-
func (s Severity) String() string {
19-
if int(s) < len(severityNames) {
20-
return severityNames[s]
21-
}
22-
return "unknown"
23-
}
24-
2518
// ParseSeverity converts a string to a Severity.
26-
func ParseSeverity(s string) Severity {
27-
switch strings.ToLower(strings.TrimSpace(s)) {
28-
case "critical":
29-
return SeverityCritical
30-
case "high":
31-
return SeverityHigh
32-
case "medium":
33-
return SeverityMedium
34-
case "low":
35-
return SeverityLow
36-
default:
37-
return SeverityInfo
38-
}
39-
}
40-
41-
// AtLeast returns true if s >= threshold.
42-
func (s Severity) AtLeast(threshold Severity) bool {
43-
return s >= threshold
44-
}
19+
var ParseSeverity = types.ParseSeverity

0 commit comments

Comments
 (0)