Prefer parameterized logging (#1977)

* Initial plan

* Replace string templates with {} placeholder styles for logging

Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>
Co-authored-by: Zongle Wang <wangzongler@gmail.com>

Author: Copilot

src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.kt

@@ -82,11 +82,15 @@ constructor(private val softwareComponentFactory: SoftwareComponentFactory) : Pl
     afterEvaluate {
       if (shadow.addTargetJvmVersionAttribute.get()) {
         logger.info(
-          "Setting ${TargetJvmVersion.TARGET_JVM_VERSION_ATTRIBUTE.name} attribute for ${shadowRuntimeElements.name} configuration."
+          "Setting {} attribute for {} configuration.",
+          TargetJvmVersion.TARGET_JVM_VERSION_ATTRIBUTE.name,
+          shadowRuntimeElements.name,
         )
       } else {
         logger.info(
-          "Skipping setting ${TargetJvmVersion.TARGET_JVM_VERSION_ATTRIBUTE.name} attribute for ${shadowRuntimeElements.name} configuration."
+          "Skipping setting {} attribute for {} configuration.",
+          TargetJvmVersion.TARGET_JVM_VERSION_ATTRIBUTE.name,
+          shadowRuntimeElements.name,
         )
         return@afterEvaluate
       }
@@ -105,7 +109,9 @@ constructor(private val softwareComponentFactory: SoftwareComponentFactory) : Pl
         )
       } else {
         logger.info(
-          "Setting target JVM version to $targetJvmVersion for ${shadowRuntimeElements.name} configuration."
+          "Setting target JVM version to {} for {} configuration.",
+          targetJvmVersion,
+          shadowRuntimeElements.name,
         )
         shadowRuntimeElements.configure {
           it.attributes { attrs ->
@@ -127,9 +133,9 @@ constructor(private val softwareComponentFactory: SoftwareComponentFactory) : Pl
     // addShadowVariantIntoJavaComponent.
     afterEvaluate {
       if (shadow.addShadowVariantIntoJavaComponent.get()) {
-        logger.info("Adding ${shadowRuntimeElements.name} variant to Java component.")
+        logger.info("Adding {} variant to Java component.", shadowRuntimeElements.name)
       } else {
-        logger.info("Skipping adding ${shadowRuntimeElements.name} variant to Java component.")
+        logger.info("Skipping adding {} variant to Java component.", shadowRuntimeElements.name)
         return@afterEvaluate
       }
       components.named("java", AdhocComponentWithVariants::class.java) {

src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowKmpPlugin.kt

@@ -21,7 +21,9 @@ public abstract class ShadowKmpPlugin : Plugin<Project> {
           // Declaring multiple Kotlin Targets of the same type is not supported. See
           // https://kotl.in/declaring-multiple-targets for more details.
           logger.info(
-            "$SHADOW_JAR_TASK_NAME task already exists, skipping configuration for target: ${target.name}"
+            "{} task already exists, skipping configuration for target: {}",
+            SHADOW_JAR_TASK_NAME,
+            target.name,
           )
           return@configureEach
         }

src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowCopyAction.kt

@@ -148,7 +148,7 @@ constructor(
   private inner class StreamAction(private val zipOutStr: ZipOutputStream) :
     CopyActionProcessingStreamAction {
     init {
-      logger.info("Relocator count: ${relocators.size}.")
+      logger.info("Relocator count: {}.", relocators.size)
       if (encoding != null) {
         zipOutStr.setEncoding(encoding)
       }
@@ -202,7 +202,7 @@ constructor(
       val className = classPath.substringBeforeLast(".").replace('/', '.')
       return unusedClasses.contains(className).also {
         if (it) {
-          logger.info("Dropping unused class: $className")
+          logger.info("Dropping unused class: {}", className)
         }
       }
     }

src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt

@@ -543,7 +543,8 @@ public abstract class ShadowJar : Jar() {
     get() {
       if (enableAutoRelocation.get()) {
         logger.info(
-          "Adding auto relocation packages in the dependencies with prefix '${relocationPrefix.get()}'."
+          "Adding auto relocation packages in the dependencies with prefix '{}'.",
+          relocationPrefix.get(),
         )
       } else {
         logger.info("Skipping package relocators as auto relocation is disabled.")
@@ -568,18 +569,22 @@ public abstract class ShadowJar : Jar() {
     when {
       manifest.attributes.contains(mainClassAttributeKey) -> {
         logger.info(
-          "Skipping adding $mainClassAttributeKey attribute to the manifest as it is already set."
+          "Skipping adding {} attribute to the manifest as it is already set.",
+          mainClassAttributeKey,
         )
       }
       mainClassValue.isNullOrEmpty() -> {
         logger.info(
-          "Skipping adding $mainClassAttributeKey attribute to the manifest as it is empty."
+          "Skipping adding {} attribute to the manifest as it is empty.",
+          mainClassAttributeKey,
         )
       }
       else -> {
         manifest.attributes[mainClassAttributeKey] = mainClassValue
         logger.info(
-          "Adding $mainClassAttributeKey attribute to the manifest with value '$mainClassValue'."
+          "Adding {} attribute to the manifest with value '{}'.",
+          mainClassAttributeKey,
+          mainClassValue,
         )
       }
     }
@@ -593,11 +598,13 @@ public abstract class ShadowJar : Jar() {
 
     if (addMultiReleaseAttribute.get()) {
       logger.info(
-        "Adding $multiReleaseAttributeKey attribute to the manifest if any dependencies contain it."
+        "Adding {} attribute to the manifest if any dependencies contain it.",
+        multiReleaseAttributeKey,
       )
     } else {
       logger.info(
-        "Skipping adding $multiReleaseAttributeKey attribute to the manifest as it is disabled."
+        "Skipping adding {} attribute to the manifest as it is disabled.",
+        multiReleaseAttributeKey,
       )
       return
     }