Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.6.X: eow does not respect weekstart #3629

Open
elig0n opened this issue Sep 22, 2024 · 2 comments
Open

2.6.X: eow does not respect weekstart #3629

elig0n opened this issue Sep 22, 2024 · 2 comments
Labels
topic:time Issues relating to time

Comments

@elig0n
Copy link

elig0n commented Sep 22, 2024

  • What command(s) did you run?

.taskrc contains:

weekstart=Sunday

and I ran:

task XXX modify due:eow
  • What did you expect to happen?

Have due set to next Sunday

  • What actually happened?

For today Sunday the 22th, the end of the day i.e. Monday the 23rd was set as due date (only few hours left).

@djmitche
Copy link
Collaborator

@smemsh I think this is what you mentioned as a known bug in #3623 (comment)?

@djmitche djmitche added the topic:time Issues relating to time label Sep 22, 2024
@smemsh
Copy link
Contributor

smemsh commented Sep 23, 2024

Right now rc.weekstart is only used for "task calendar" afaict, and is not used to set Datetime::weekstart in libshared. In any case setting that for libshared would not fix everything that is influenced by the week start to be able to work with different values.

For the relative week shortcuts like eow, Taskwarrior currently uses Monday based weeks (first day of week starting mon 00:00:00), but if absolute week numbers are given like 2014-W30 those will use Sunday weeks.

Updating libshared will fix absolute week numbers to parse into dates based on [the monday-based] ISO8601. It would not fix the relative dates to respect rc.weekstart. So that is the additional work in aforementioned issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:time Issues relating to time
Projects
Status: Backlog
Development

No branches or pull requests

3 participants