Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version property #159

Closed
ltc opened this issue Oct 15, 2016 · 1 comment
Closed

Add version property #159

ltc opened this issue Oct 15, 2016 · 1 comment
Labels
enhancement
Milestone
Comprehensive API

Comments

@ltc
Copy link

ltc commented Oct 15, 2016

It would be useful to add a "version" string property to google-chart to load a different version of the charts library. This can be a specific version or the special strings, "upcoming" and "current". This will be useful when testing out upcoming releases or freezing an app to a specific version.

This would also be consistent with google-map, which also offers a version string property:
https://elements.polymer-project.org/elements/google-map#property-version

Details: https://developers.google.com/chart/interactive/docs/basic_load_libs

I'll send a PR that adds the version string property to google-chart and google-chart-loader.
@ltc ltc mentioned this issue Oct 15, 2016
Closed
@wesalvaro wesalvaro mentioned this issue Oct 18, 2016
Closed
wesalvaro added a commit to wesalvaro/google-chart that referenced this issue Oct 18, 2016
@wesalvaro
Utilizes dynamic package loading.
9195cc2 
Loading packages dynamically means that language and version
may not be changed. This fixes GoogleWebComponents#145 and GoogleWebComponents#159 for setting them
consistently across all loaders and preventing them from changing.

Adds a new test file for language testing as we are loading a
different set of library files.
wesalvaro added a commit to wesalvaro/google-chart that referenced this issue Oct 18, 2016
@wesalvaro
Utilizes dynamic package loading.
829566a 
Loading packages dynamically means that language and version
may not be changed. This fixes GoogleWebComponents#145 and GoogleWebComponents#159 for setting them
consistently across all loaders and preventing them from changing.

Adds a new test file for language testing as we are loading a
different set of library files.
@wesalvaro wesalvaro added this to the Comprehensive API milestone Jan 12, 2018
@rslawik
Copy link
Contributor

rslawik commented Sep 20, 2019

Google Charts library can be loaded with custom settings - see the load function introduce in #245. Example usage in custom-load-test.

It is not a property because the library is loaded only once globally.

@rslawik rslawik closed this as completed Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Comprehensive API
Development

No branches or pull requests
3 participants
@wesalvaro @ltc @rslawik