Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] - Allow passing custom GCB build config (KMS, secrets, steps, config) #1262

Closed
ss-vdav-debug opened this issue Nov 9, 2018 · 4 comments

Comments

@ss-vdav-debug
Copy link

ss-vdav-debug commented Nov 9, 2018

While trying to review the possibility to implement the development workflows with Skaffold,
I found that currently there is no secure way to pass encrypted credentials.

For many companies it is required to be able to follow KMS based key decryption
https://cloud.google.com/cloud-build/docs/access-private-github-repos

Expected behavior

Actual behavior

Information

  • Skaffold version: 0.18.0
  • Operating system: All
  • Contents of typical build configuration within GCB:
timeout: 1200s
images: ['${_IMAGE}']
steps:
- name: 'gcr.io/cloud-builders/docker'
  entrypoint: 'bash'
  args: ['-c', 'docker build --build-arg GITHUB_PRIVATE_KEY="$$GITHUB_PRIVATE_KEY" -t ${_IMAGE} .']
  secretEnv: ['GITHUB_PRIVATE_KEY']
options:
 logging: GCS_ONLY
secrets:
- kmsKeyName: <<<KEY>>>
  secretEnv:
    GITHUB_PRIVATE_KEY: <<<PRIVATE_KEY>>>

Steps to reproduce the behavior

Try to follow KMS build workflow.

@roychowdhuryrohit-dev
Copy link

roychowdhuryrohit-dev commented Feb 7, 2019

I would like skaffold to use the local cloudbuild.yaml instead of it's own stanza as Google Cloud Build supports additional options and tags.

@Place1
Copy link

Place1 commented Mar 14, 2019

This sounds related to #543

@priyawadhwa
Copy link
Contributor

@roychowdhuryrohit-dev we just added support for custom builders with skaffold, which should solve your use case.

Here's an example using a custom build script and associated docs. If you end up trying it out, please open an issue if you run into any trouble, and let us know if it works for you!

@priyawadhwa priyawadhwa added the priority/p1 High impact feature/bug. label Oct 1, 2019
@tstromberg
Copy link
Contributor

Thank you for the idea! I

I'm closing this issue as it's been open a while, and no one has yet stated an interest in addressing it. If you feels strongly about this issue, feel free to comment here or re-raise an issue referencing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants