Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade workflow to run unit tests in Java 17 - the latest LTS #3139

Open
yrashish opened this issue Mar 16, 2021 · 6 comments
Open

Upgrade workflow to run unit tests in Java 17 - the latest LTS #3139

yrashish opened this issue Mar 16, 2021 · 6 comments

Comments

@yrashish
Copy link
Contributor

yrashish commented Mar 16, 2021

Java 16 is GA. Let me know if we can upgrade the workflow yml file to include JDK 16 also as part of running the unit test.

@yrashish yrashish changed the title Upgrade workflow to consider Java 16 Upgrade workflow to consider Java 16 for unit tests Mar 16, 2021
@chanseokoh
Copy link
Member

Sure thing! Will be interesting to see if it works. (I expect it will.)

@chanseokoh
Copy link
Member

But probably we will replace 16 with 17 (instead of just adding 17) when it gets out. For efficiency, we don't want to test on every Java version. Probably only LTS versions.

@yrashish
Copy link
Contributor Author

So can I make the change?. I understand that it's much efficient to stick with the LTS version. Still, In my opinion, it would be good to have at least one or two non-LTS versions for unit tests to understand compatibility with different JDK versions. Thoughts?

@chanseokoh
Copy link
Member

Sure, go ahead. I was just mentioning that when 17 comes out, we will probably drop 16.

@ddixit14 ddixit14 changed the title Upgrade workflow to consider Java 16 for unit tests Upgrade workflow to run unit tests in Java 17 - the latest LTS Aug 2, 2022
@ddixit14
Copy link

ddixit14 commented Aug 2, 2022

Modified the title to "Upgrade workflow to java 17 (the latest LTS) "

@rquinio
Copy link
Contributor

rquinio commented Nov 19, 2023

This seems urgent due to sonarcloud warning

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more [here](https://docs.sonarsource.com/sonarcloud/appendices/scanner-environment/)

Prerequisite is update to a Gradle version that supports Java 17 (cf https://docs.gradle.org/current/userguide/compatibility.html#java): #4139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants