Skip to content

Conversation

@pisto
Copy link
Contributor

@pisto pisto commented Dec 5, 2024

Fixes #101 . The change has been tested.

Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@spowelljr spowelljr merged commit a58a8f9 into GoogleContainerTools:main Dec 12, 2024
2 checks passed
@pisto pisto deleted the service-account-key-fix-oauth-scope branch December 15, 2024 15:37
@sorenhansendk
Copy link

Hi @spowelljr 👋

Would you be able to cut a new release, when you have a moment? We rely on the fix from #169 (correct OAuth scopes when using service account keys) and would love to consume it via a tagged version.

Thanks so much for your time and for maintaining this project! 🙏

@spowelljr
Copy link
Member

Hi @sorenhansendk, I don't actively work on this project anymore, however I do have the power to cut a release. It looks like there's a fix for the mentioned PR #209, but it's waiting on a CLA fixed. Once the CLA is fixed I'm happy to help cut a new release.

@sorenhansendk
Copy link

Once the CLA is fixed I'm happy to help cut a new release.

Great, thank you @spowelljr 👍

@Baune8D
Copy link
Contributor

Baune8D commented Oct 6, 2025

Hi @spowelljr

We also really need these changes. Would it be okay to open a new PR with the same basic changes as #209 so we can get a new release going? 🙂

@spowelljr
Copy link
Member

@Baune8D It's been two months since the last action by the author, I'm happy to accept a new PR.

@Baune8D
Copy link
Contributor

Baune8D commented Oct 9, 2025

@Baune8D It's been two months since the last action by the author, I'm happy to accept a new PR.

Done #223 👍 And CLA should be signed 🤞

@spowelljr
Copy link
Member

spowelljr commented Oct 9, 2025

I created the PR to create a new release, just need to get it approved. I have the power to cut a new release in GitHub, but I no longer have the power to push the image to AR, I'll need @medyagh to handle that.

#224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auth issue when using service account credentials file

4 participants