Auto RAG Eval: Automated Benchmark Generation for RAG Systems - #2522
Merged
Conversation
tanyagoogle
changed the title
holtskinner
requested changes
Dec 1, 2025
Collaborator
There was a problem hiding this comment.
Delete the duplicated files, and place the auto-rag-eval folder in the top-level search/ directory since this uses Vertex AI Search.
Collaborator
There was a problem hiding this comment.
This isn't needed. Already have one in the repo.
Collaborator
There was a problem hiding this comment.
This isn't needed. Already have one in the repo.
holtskinner
requested changes
Dec 5, 2025
Comment on lines
+869
to
+928
| mance | ||
| MBPP | ||
| Mingchuan | ||
| mizer | ||
| Mmeory | ||
| Multipl | ||
| NICs | ||
| nology | ||
| Noune | ||
| NUMA | ||
| nvlink | ||
| NVMe | ||
| Odena | ||
| Omran | ||
| opti | ||
| Panpan | ||
| perfor | ||
| pgomran | ||
| Piao | ||
| PIQA | ||
| Pouya | ||
| Qihao | ||
| rameters | ||
| RDMA | ||
| Rudce | ||
| Sabharwal | ||
| Scal | ||
| Schoenick | ||
| Shirong | ||
| Shuiping | ||
| Specfic | ||
| Splited | ||
| SSDs | ||
| strat | ||
| Sutskever | ||
| Tafjord | ||
| taneously | ||
| tation | ||
| tentially | ||
| tergeted | ||
| Tezak | ||
| tional | ||
| tions | ||
| Touvron | ||
| trast | ||
| trol | ||
| Tworek | ||
| vances | ||
| VLs | ||
| Wenfeng | ||
| Wentao | ||
| Wgrad | ||
| Yaofeng | ||
| Yingfei | ||
| Yishi | ||
| Zhenda | ||
| Zhewen | ||
| Zhihong | ||
| zhuqh | ||
| Zoph |
Collaborator
There was a problem hiding this comment.
Several of these are actual misspellings which shouldn't be added to the allowlist.
Comment on lines
+256
to
+258
|
|
||
| # Forbidden pattern: Don't use Gemini 1.X | ||
| gemini-1\.[05] |
Collaborator
There was a problem hiding this comment.
Undo this change, it should already be in the forbidden patterns.
Collaborator
|
@gemini-code-assist review |
Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com>
holtskinner
approved these changes
Dec 8, 2025
leebaro
pushed a commit
to leebaro/generative-ai
that referenced
this pull request
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.CODEOWNERSfor the file(s).nox -s formatfrom the repository root to format).Fixes #<issue_number_goes_here> 🦕