Skip to content

Proposition to not format Trace SpanID  #24

@theok-nice

Description

@theok-nice

When using the plugin, I have noticed that SpanIDs are formatted.

spanIDField.Append(strconv.FormatUint(s.GetSpanId(), 10))

https://github.com/GoogleCloudPlatform/cloud-trace-data-source-plugin/blob/2926fd2d77f30b927663605524ef788d0d014eef/pkg/plugin/plugin.go#L297C3-L297C14

Problem is that makes the Span IDs "unusable":
Say you want to use this ID to check the logs for specific SpanId. Google Cloud Logging expects the spanID in '016x' format, as it is originally set in the Trace span metadata.

I would like to propose that the plugin wouldn't format the spanIDs.

I have tried to format the ID back to '016x' using Grafana variables and Big Query

DECLARE spanIDString STRING;
SET spanIDString = "$span_id";

SELECT FORMAT("%016x", CAST(spanIDString AS INT64)) AS spanID;

but there are times where the spanID is getting (from the plugin) a value too large to be cast as an INT64. So my workaround doesn't work either.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions