Improve error messages in packageupgrade_test.go. The error messages for failed package installations now include both stdout and stderr from the command execution, providing more context for debugging.

ChaitanyaKulkarni28 · copybara-github · commit 79b34bc1f247 · 2026-01-09T09:35:10.000-08:00
PiperOrigin-RevId: 854049826
diff --git a/test_suites/packageupgrade/packageupgrade_test.go b/test_suites/packageupgrade/packageupgrade_test.go
@@ -62,7 +62,7 @@ func VerifyInstallReturn(t *testing.T, pkg string, input string) {
 	if matchedInstall || matchedNoaction {
 		return
 	}
-	t.Fatalf("Installation of '%s' returned unexpected result: %s", pkg, input)
+	t.Fatalf("Installation of %q returned unexpected result: %s", pkg, input)
 }
 
 func TestPvpanicDriverInstallFromTesting(t *testing.T) {
@@ -73,7 +73,7 @@ func TestPvpanicDriverInstallFromTesting(t *testing.T) {
 	command := fmt.Sprintf("%s -noconfirm install %s", googet, driver)
 	output, err := utils.RunPowershellCmd(command)
 	if err != nil {
-		t.Fatalf("Error installing '%s': %v", driver, output.Stdout)
+		t.Fatalf("Error installing %q: stdout: %s, stderr: %s", driver, output.Stdout, output.Stderr)
 	}
 	VerifyInstallReturn(t, driver, output.Stdout)
 }
@@ -86,7 +86,7 @@ func TestGgaDriverInstallFromTesting(t *testing.T) {
 	command := fmt.Sprintf("%s -noconfirm install %s", googet, driver)
 	output, err := utils.RunPowershellCmd(command)
 	if err != nil {
-		t.Fatalf("Error installing '%s': %v", driver, output.Stdout)
+		t.Fatalf("Error installing %q: stdout: %s, stderr: %s", driver, output.Stdout, output.Stderr)
 	}
 	VerifyInstallReturn(t, driver, output.Stdout)
 }
@@ -99,7 +99,7 @@ func TestBalloonDriverInstallFromTesting(t *testing.T) {
 	command := fmt.Sprintf("%s -noconfirm install %s", googet, driver)
 	output, err := utils.RunPowershellCmd(command)
 	if err != nil {
-		t.Fatalf("Error installing '%s': %v", driver, output.Stdout)
+		t.Fatalf("Error installing %q: stdout: %s, stderr: %s", driver, output.Stdout, output.Stderr)
 	}
 	VerifyInstallReturn(t, driver, output.Stdout)
 }
@@ -112,7 +112,7 @@ func TestGvnicDriverInstallFromTesting(t *testing.T) {
 	command := fmt.Sprintf("%s -noconfirm install %s", googet, driver)
 	output, err := utils.RunPowershellCmd(command)
 	if err != nil {
-		t.Fatalf("Error installing '%s': %v", driver, output.Stdout)
+		t.Fatalf("Error installing %q: stdout: %s, stderr: %s", driver, output.Stdout, output.Stderr)
 	}
 	VerifyInstallReturn(t, driver, output.Stdout)
 }
@@ -125,7 +125,7 @@ func TestNetkvmDriverInstallFromTesting(t *testing.T) {
 	command := fmt.Sprintf("%s -noconfirm install %s", googet, driver)
 	output, err := utils.RunPowershellCmd(command)
 	if err != nil {
-		t.Fatalf("Error installing '%s': %v", driver, output.Stdout)
+		t.Fatalf("Error installing %q: stdout: %s, stderr: %s", driver, output.Stdout, output.Stderr)
 	}
 	VerifyInstallReturn(t, driver, output.Stdout)
 }
@@ -138,7 +138,7 @@ func TestVioscsiDriverInstallFromTesting(t *testing.T) {
 	command := fmt.Sprintf("%s -noconfirm install %s", googet, driver)
 	output, err := utils.RunPowershellCmd(command)
 	if err != nil {
-		t.Fatalf("Error installing '%s': %v", driver, output.Stdout)
+		t.Fatalf("Error installing %q: stdout: %s, stderr: %s", driver, output.Stdout, output.Stderr)
 	}
 	VerifyInstallReturn(t, driver, output.Stdout)
 }
@@ -151,7 +151,7 @@ func TestCertgenPackageInstallFromTesting(t *testing.T) {
 	command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)
 	output, err := utils.RunPowershellCmd(command)
 	if err != nil {
-		t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)
+		t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)
 	}
 	VerifyInstallReturn(t, pkg, output.Stdout)
 }
@@ -164,7 +164,7 @@ func TestGoogetPackageInstallFromTesting(t *testing.T) {
 	command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)
 	output, err := utils.RunPowershellCmd(command)
 	if err != nil {
-		t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)
+		t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)
 	}
 	VerifyInstallReturn(t, pkg, output.Stdout)
 }
@@ -177,7 +177,7 @@ func TestGceDiagnosticsPackageInstallFromTesting(t *testing.T) {
 	command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)
 	output, err := utils.RunPowershellCmd(command)
 	if err != nil {
-		t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)
+		t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)
 	}
 	VerifyInstallReturn(t, pkg, output.Stdout)
 }
@@ -190,7 +190,7 @@ func TestGceMetadataScriptsPackageInstallFromTesting(t *testing.T) {
 	command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)
 	output, err := utils.RunPowershellCmd(command)
 	if err != nil {
-		t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)
+		t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)
 	}
 	VerifyInstallReturn(t, pkg, output.Stdout)
 }
@@ -203,7 +203,7 @@ func TestGcePowershellPackageInstallFromTesting(t *testing.T) {
 	command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)
 	output, err := utils.RunPowershellCmd(command)
 	if err != nil {
-		t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)
+		t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)
 	}
 	VerifyInstallReturn(t, pkg, output.Stdout)
 }
@@ -216,7 +216,7 @@ func TestGceSysprepPackageInstallFromTesting(t *testing.T) {
 	command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)
 	output, err := utils.RunPowershellCmd(command)
 	if err != nil {
-		t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)
+		t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)
 	}
 	VerifyInstallReturn(t, pkg, output.Stdout)
 }
@@ -229,7 +229,7 @@ func TestWindowsGuestAgentInstallFromTesting(t *testing.T) {
 	command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)
 	output, err := utils.RunPowershellCmd(command)
 	if err != nil {
-		t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)
+		t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)
 	}
 	VerifyInstallReturn(t, pkg, output.Stdout)
 }
@@ -242,7 +242,7 @@ func TestOSConfigAgentInstallFromTesting(t *testing.T) {
 	command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)
 	output, err := utils.RunPowershellCmd(command)
 	if err != nil {
-		t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)
+		t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)
 	}
 	VerifyInstallReturn(t, pkg, output.Stdout)
 }

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ func VerifyInstallReturn(t *testing.T, pkg string, input string) {`
`62`	`62`	`if matchedInstall \|\| matchedNoaction {`
`63`	`63`	`return`
`64`	`64`	`}`
`65`		`- t.Fatalf("Installation of '%s' returned unexpected result: %s", pkg, input)`
	`65`	`+ t.Fatalf("Installation of %q returned unexpected result: %s", pkg, input)`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`func TestPvpanicDriverInstallFromTesting(t *testing.T) {`
`@@ -73,7 +73,7 @@ func TestPvpanicDriverInstallFromTesting(t *testing.T) {`
`73`	`73`	`command := fmt.Sprintf("%s -noconfirm install %s", googet, driver)`
`74`	`74`	`output, err := utils.RunPowershellCmd(command)`
`75`	`75`	`if err != nil {`
`76`		`- t.Fatalf("Error installing '%s': %v", driver, output.Stdout)`
	`76`	`+ t.Fatalf("Error installing %q: stdout: %s, stderr: %s", driver, output.Stdout, output.Stderr)`
`77`	`77`	`}`
`78`	`78`	`VerifyInstallReturn(t, driver, output.Stdout)`
`79`	`79`	`}`
`@@ -86,7 +86,7 @@ func TestGgaDriverInstallFromTesting(t *testing.T) {`
`86`	`86`	`command := fmt.Sprintf("%s -noconfirm install %s", googet, driver)`
`87`	`87`	`output, err := utils.RunPowershellCmd(command)`
`88`	`88`	`if err != nil {`
`89`		`- t.Fatalf("Error installing '%s': %v", driver, output.Stdout)`
	`89`	`+ t.Fatalf("Error installing %q: stdout: %s, stderr: %s", driver, output.Stdout, output.Stderr)`
`90`	`90`	`}`
`91`	`91`	`VerifyInstallReturn(t, driver, output.Stdout)`
`92`	`92`	`}`
`@@ -99,7 +99,7 @@ func TestBalloonDriverInstallFromTesting(t *testing.T) {`
`99`	`99`	`command := fmt.Sprintf("%s -noconfirm install %s", googet, driver)`
`100`	`100`	`output, err := utils.RunPowershellCmd(command)`
`101`	`101`	`if err != nil {`
`102`		`- t.Fatalf("Error installing '%s': %v", driver, output.Stdout)`
	`102`	`+ t.Fatalf("Error installing %q: stdout: %s, stderr: %s", driver, output.Stdout, output.Stderr)`
`103`	`103`	`}`
`104`	`104`	`VerifyInstallReturn(t, driver, output.Stdout)`
`105`	`105`	`}`
`@@ -112,7 +112,7 @@ func TestGvnicDriverInstallFromTesting(t *testing.T) {`
`112`	`112`	`command := fmt.Sprintf("%s -noconfirm install %s", googet, driver)`
`113`	`113`	`output, err := utils.RunPowershellCmd(command)`
`114`	`114`	`if err != nil {`
`115`		`- t.Fatalf("Error installing '%s': %v", driver, output.Stdout)`
	`115`	`+ t.Fatalf("Error installing %q: stdout: %s, stderr: %s", driver, output.Stdout, output.Stderr)`
`116`	`116`	`}`
`117`	`117`	`VerifyInstallReturn(t, driver, output.Stdout)`
`118`	`118`	`}`
`@@ -125,7 +125,7 @@ func TestNetkvmDriverInstallFromTesting(t *testing.T) {`
`125`	`125`	`command := fmt.Sprintf("%s -noconfirm install %s", googet, driver)`
`126`	`126`	`output, err := utils.RunPowershellCmd(command)`
`127`	`127`	`if err != nil {`
`128`		`- t.Fatalf("Error installing '%s': %v", driver, output.Stdout)`
	`128`	`+ t.Fatalf("Error installing %q: stdout: %s, stderr: %s", driver, output.Stdout, output.Stderr)`
`129`	`129`	`}`
`130`	`130`	`VerifyInstallReturn(t, driver, output.Stdout)`
`131`	`131`	`}`
`@@ -138,7 +138,7 @@ func TestVioscsiDriverInstallFromTesting(t *testing.T) {`
`138`	`138`	`command := fmt.Sprintf("%s -noconfirm install %s", googet, driver)`
`139`	`139`	`output, err := utils.RunPowershellCmd(command)`
`140`	`140`	`if err != nil {`
`141`		`- t.Fatalf("Error installing '%s': %v", driver, output.Stdout)`
	`141`	`+ t.Fatalf("Error installing %q: stdout: %s, stderr: %s", driver, output.Stdout, output.Stderr)`
`142`	`142`	`}`
`143`	`143`	`VerifyInstallReturn(t, driver, output.Stdout)`
`144`	`144`	`}`
`@@ -151,7 +151,7 @@ func TestCertgenPackageInstallFromTesting(t *testing.T) {`
`151`	`151`	`command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)`
`152`	`152`	`output, err := utils.RunPowershellCmd(command)`
`153`	`153`	`if err != nil {`
`154`		`- t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)`
	`154`	`+ t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)`
`155`	`155`	`}`
`156`	`156`	`VerifyInstallReturn(t, pkg, output.Stdout)`
`157`	`157`	`}`
`@@ -164,7 +164,7 @@ func TestGoogetPackageInstallFromTesting(t *testing.T) {`
`164`	`164`	`command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)`
`165`	`165`	`output, err := utils.RunPowershellCmd(command)`
`166`	`166`	`if err != nil {`
`167`		`- t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)`
	`167`	`+ t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)`
`168`	`168`	`}`
`169`	`169`	`VerifyInstallReturn(t, pkg, output.Stdout)`
`170`	`170`	`}`
`@@ -177,7 +177,7 @@ func TestGceDiagnosticsPackageInstallFromTesting(t *testing.T) {`
`177`	`177`	`command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)`
`178`	`178`	`output, err := utils.RunPowershellCmd(command)`
`179`	`179`	`if err != nil {`
`180`		`- t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)`
	`180`	`+ t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)`
`181`	`181`	`}`
`182`	`182`	`VerifyInstallReturn(t, pkg, output.Stdout)`
`183`	`183`	`}`
`@@ -190,7 +190,7 @@ func TestGceMetadataScriptsPackageInstallFromTesting(t *testing.T) {`
`190`	`190`	`command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)`
`191`	`191`	`output, err := utils.RunPowershellCmd(command)`
`192`	`192`	`if err != nil {`
`193`		`- t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)`
	`193`	`+ t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)`
`194`	`194`	`}`
`195`	`195`	`VerifyInstallReturn(t, pkg, output.Stdout)`
`196`	`196`	`}`
`@@ -203,7 +203,7 @@ func TestGcePowershellPackageInstallFromTesting(t *testing.T) {`
`203`	`203`	`command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)`
`204`	`204`	`output, err := utils.RunPowershellCmd(command)`
`205`	`205`	`if err != nil {`
`206`		`- t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)`
	`206`	`+ t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)`
`207`	`207`	`}`
`208`	`208`	`VerifyInstallReturn(t, pkg, output.Stdout)`
`209`	`209`	`}`
`@@ -216,7 +216,7 @@ func TestGceSysprepPackageInstallFromTesting(t *testing.T) {`
`216`	`216`	`command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)`
`217`	`217`	`output, err := utils.RunPowershellCmd(command)`
`218`	`218`	`if err != nil {`
`219`		`- t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)`
	`219`	`+ t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)`
`220`	`220`	`}`
`221`	`221`	`VerifyInstallReturn(t, pkg, output.Stdout)`
`222`	`222`	`}`
`@@ -229,7 +229,7 @@ func TestWindowsGuestAgentInstallFromTesting(t *testing.T) {`
`229`	`229`	`command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)`
`230`	`230`	`output, err := utils.RunPowershellCmd(command)`
`231`	`231`	`if err != nil {`
`232`		`- t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)`
	`232`	`+ t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)`
`233`	`233`	`}`
`234`	`234`	`VerifyInstallReturn(t, pkg, output.Stdout)`
`235`	`235`	`}`
`@@ -242,7 +242,7 @@ func TestOSConfigAgentInstallFromTesting(t *testing.T) {`
`242`	`242`	`command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)`
`243`	`243`	`output, err := utils.RunPowershellCmd(command)`
`244`	`244`	`if err != nil {`
`245`		`- t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)`
	`245`	`+ t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)`
`246`	`246`	`}`
`247`	`247`	`VerifyInstallReturn(t, pkg, output.Stdout)`
`248`	`248`	`}`