Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx README instructions missing exporter.image #1741

Open
1 of 3 tasks
EtiennePerot opened this issue Apr 29, 2022 · 1 comment
Open
1 of 3 tasks

nginx README instructions missing exporter.image #1741

EtiennePerot opened this issue Apr 29, 2022 · 1 comment
Labels
kind/k8s Related to the Kubernetes application needs-triage This wasn't investigate by the repo's owners yet

Comments

@EtiennePerot
Copy link

Category:

Kubernetes apps

Type:

  • Bug
  • Feature Request
  • Process

The instructions on how to deploy nginx in the README file are broken. They omit exporter.image in the helm command-line, which is referenced by nginx-statefulset.yaml here.
@EtiennePerot EtiennePerot added kind/k8s Related to the Kubernetes application needs-triage This wasn't investigate by the repo's owners yet labels Apr 29, 2022
feitnomore added a commit to feitnomore/click-to-deploy that referenced this issue Jun 17, 2022
@feitnomore
Update TAG version and add exporter image
e3ca5f2 
This PR adds the exporter image related to issue GoogleCloudPlatform#1741
Also, this updates the TAG to use 1.20.
@feitnomore feitnomore mentioned this issue Jun 17, 2022
Merged
armandomiani pushed a commit that referenced this issue Jun 22, 2022
@feitnomore
Update TAG version and add exporter image (#1802)
17e35ca 
This PR adds the exporter image related to issue #1741
Also, this updates the TAG to use 1.20.
@armandomiani
Copy link
Member

https://github.com/GoogleCloudPlatform/click-to-deploy/tree/master/k8s/nginx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/k8s Related to the Kubernetes application needs-triage This wasn't investigate by the repo's owners yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@armandomiani @EtiennePerot