Skip to content

Commit f2cf7f6

Browse files
philipwaltonjeffposnick
authored andcommitted
Update jsdoc comments to use package names (#2312)
* Update jsdoc comments to use package names * Add missing jsdoc updates * Fix failing integration tests * Fix failing integration tests (again)
1 parent 334c229 commit f2cf7f6

File tree

82 files changed

+323
-310
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

82 files changed

+323
-310
lines changed

packages/workbox-background-sync/src/BackgroundSyncPlugin.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,16 @@ import './_version.js';
1414
* A class implementing the `fetchDidFail` lifecycle callback. This makes it
1515
* easier to add failed requests to a background sync Queue.
1616
*
17-
* @memberof workbox.backgroundSync
17+
* @memberof module:workbox-background-sync
1818
*/
1919
class BackgroundSyncPlugin implements WorkboxPlugin {
2020
private _queue: Queue;
2121

2222
/**
23-
* @param {string} name See the [Queue]{@link workbox.backgroundSync.Queue}
23+
* @param {string} name See the [Queue]{@link module:workbox-background-sync.Queue}
2424
* documentation for parameter details.
2525
* @param {Object} [options] See the
26-
* [Queue]{@link workbox.backgroundSync.Queue} documentation for
26+
* [Queue]{@link module:workbox-background-sync.Queue} documentation for
2727
* parameter details.
2828
*/
2929
constructor(name: string, options: QueueOptions) {

packages/workbox-background-sync/src/Queue.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ const queueNames = new Set();
4747
* later. All parts of the storing and replaying process are observable via
4848
* callbacks.
4949
*
50-
* @memberof workbox.backgroundSync
50+
* @memberof module:workbox-background-sync
5151
*/
5252
class Queue {
5353
private _name: string;

packages/workbox-background-sync/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import './_version.js';
1212

1313

1414
/**
15-
* @namespace workbox.backgroundSync
15+
* @module workbox-background-sync
1616
*/
1717

1818
export {

packages/workbox-background-sync/src/lib/QueueStore.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ export class QueueStore {
149149
/**
150150
* Returns all entries in the store matching the `queueName`.
151151
*
152-
* @param {Object} options See workbox.backgroundSync.Queue~getAll}
152+
* @param {Object} options See {@link module:workbox-background-sync.Queue~getAll}
153153
* @return {Promise<Array<Object>>}
154154
* @private
155155
*/

packages/workbox-broadcast-update/src/BroadcastCacheUpdate.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ function defaultPayloadGenerator(data: CacheDidUpdateCallbackParam): Object {
5252
* For efficiency's sake, the underlying response bodies are not compared;
5353
* only specific response headers are checked.
5454
*
55-
* @memberof workbox.broadcastUpdate
55+
* @memberof module:workbox-broadcast-update
5656
*/
5757
class BroadcastCacheUpdate {
5858
private _headersToCheck: string[];

packages/workbox-broadcast-update/src/BroadcastUpdatePlugin.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@ import './_version.js';
1717
* This plugin will automatically broadcast a message whenever a cached response
1818
* is updated.
1919
*
20-
* @memberof workbox.broadcastUpdate
20+
* @memberof module:workbox-broadcast-update
2121
*/
2222
class BroadcastUpdatePlugin implements WorkboxPlugin {
2323
private _broadcastUpdate: BroadcastCacheUpdate;
2424

2525
/**
2626
* Construct a BroadcastCacheUpdate instance with the passed options and
27-
* calls its [`notifyIfUpdated()`]{@link workbox.broadcastUpdate.BroadcastCacheUpdate~notifyIfUpdated}
27+
* calls its [`notifyIfUpdated()`]{@link module:workbox-broadcast-update.BroadcastCacheUpdate~notifyIfUpdated}
2828
* method whenever the plugin's `cacheDidUpdate` callback is invoked.
2929
*
3030
* @param {Object} options

packages/workbox-broadcast-update/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import './_version.js';
1313

1414

1515
/**
16-
* @namespace workbox.broadcastUpdate
16+
* @module workbox-broadcast-update
1717
*/
1818

1919
export {

packages/workbox-broadcast-update/src/responsesAreSame.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ import './_version.js';
2020
* @param {Array<string>} headersToCheck
2121
* @return {boolean}
2222
*
23-
* @memberof workbox.broadcastUpdate
24-
* @private
23+
* @memberof module:workbox-broadcast-update
2524
*/
2625
const responsesAreSame = (
2726
firstResponse: Response,

packages/workbox-build/src/lib/module-registry.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,11 @@ const upath = require('upath');
1212
/**
1313
* Class for keeping track of which Workbox modules are used by the generated
1414
* service worker script.
15+
* @private
1516
*/
1617
class ModuleRegistry {
1718
/**
18-
* Basic constructor.
19+
* @private
1920
*/
2021
constructor() {
2122
this.modulesUsed = new Map();
@@ -24,6 +25,7 @@ class ModuleRegistry {
2425
/**
2526
* @return {Array<string>} A list of all of the import statements that are
2627
* needed for the modules being used.
28+
* @private
2729
*/
2830
getImportStatements() {
2931
const workboxModuleImports = [];
@@ -48,6 +50,7 @@ class ModuleRegistry {
4850
* @param {string} pkg The workbox package that the module belongs to.
4951
* @param {string} moduleName The name of the module to import.
5052
* @return {string} The local variable name that corresponds to that module.
53+
* @private
5154
*/
5255
getLocalName(pkg, moduleName) {
5356
return `${pkg.replace(/-/g, '_')}_${moduleName}`;
@@ -57,6 +60,7 @@ class ModuleRegistry {
5760
* @param {string} pkg The workbox package that the module belongs to.
5861
* @param {string} moduleName The name of the module to import.
5962
* @return {string} The local variable name that corresponds to that module.
63+
* @private
6064
*/
6165
use(pkg, moduleName) {
6266
const localName = this.getLocalName(pkg, moduleName);

packages/workbox-cacheable-response/src/CacheableResponse.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export interface CacheableResponseOptions {
2424
* [`Response`](https://developer.mozilla.org/en-US/docs/Web/API/Response)
2525
* to be considered cacheable.
2626
*
27-
* @memberof workbox.cacheableResponse
27+
* @memberof module:workbox-cacheable-response
2828
*/
2929
class CacheableResponse {
3030
private _statuses?: CacheableResponseOptions['statuses'];

0 commit comments

Comments
 (0)